Fix FileHandle.resize(0L) on mingwX64 - #1845
Open
czp3009 wants to merge 1 commit into
Open
Conversation
`SetFilePointer()` returns the low-order file position, so zero is valid when resizing a file to zero bytes. Treat only `INVALID_SET_FILE_POINTER` with a non-`NO_ERROR` last error as failure.
Author
|
Is there a project manager who can review and merge my PR? If there are any prerequisites for submitting a PR, please let me know—I couldn’t find any specific requirements on the project website. okio is a great project, but this bug is currently holding me up, and I’d like to start using the fixed version as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetFilePointer()returns the low-order file position, so zero is valid when resizing a file to zero bytes. Treat onlyINVALID_SET_FILE_POINTERwith a non-NO_ERRORlast error as failure.Resolve #1844