Handle 'panel.h' being in an 'ncurses' directory#23
Open
sulix wants to merge 1 commit intomadsen:masterfrom
Open
Handle 'panel.h' being in an 'ncurses' directory#23sulix wants to merge 1 commit intomadsen:masterfrom
sulix wants to merge 1 commit intomadsen:masterfrom
Conversation
Some Linux distributions (such as OpenSUSE) do not keep the ncurses 'panel.h' file in the default include path, but rather in a subdirectory. Update the configure script and curses/ConWin.hpp file to look in both places for a 'panel.h' file. 'panel.h' is still preferred over 'ncurses/panel.h', as we expect other ncurses headers to be in the include path.
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Linux distributions (such as OpenSUSE) do not keep the ncurses
panel.hfile in the default include path, but rather in asubdirectory.
Update the
configurescript andcurses/ConWin.hppfile to look in both places for apanel.hfile.panel.his still preferred overncurses/panel.h, as we expect other ncurses headers to be in the include path.(I'm neither a curses expert nor an autotools expert, so there's probably a better way of doing this. But this is probably better than nothing, and seems to roughly match what lldb did.)
This seems to have already been filed as issue #18 — which I really should've looked at before writing this. :-)