[Decomp][Spell] Cohesion split: extract SpellAuras.cpp handlers to SpellAura*.cpp - #219
Merged
Merged
Conversation
…ellAura*.cpp Mirror of mangosthree mangostwo#188-195 (bundled, same source file). Pure cohesion split of SpellAuras.cpp (12,928 -> 6,069 lines) with no behaviour change. The Aura::HandleXxx / SpellAuraHolder handlers move to dedicated TUs: - SpellAuraDummy.cpp - HandleAuraDummy. - SpellAuraControl.cpp - crowd-control + immunity handlers (carries the static frozenAuraTypes table). - SpellAuraMisc.cpp - shapeshift-boost/absorb/misc handlers. - SpellAuraShapeshift.cpp - shapeshift/movement handlers. - SpellAuraPeriodic.cpp - periodic + stat handlers. - SpellAuraTrailing.cpp - trailing handlers. - SpellAuraLate.cpp - late crit/mastery/vehicle handlers. - SpellAuraAddModifier.cpp - HandleAddModifier. SpellAuras.h is unchanged; aura holder lifecycle / ApplyModifier dispatch stay in SpellAuras.cpp. CMake file(GLOB) auto-compiles the new TUs.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 1476 |
| Duplication | 43 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codacy/Cppcheck flagged the `caster &&` condition as always-true: the method early-returns on `if (!caster)` near the top, so caster cannot be null at this point. No behaviour change.
|
❌ Build Mangos TWO Server 22.04.66 failed (commit e60447c1ae by @r-log) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of mangosthree #188-195 (bundled — all touch
SpellAuras.cpp). Pure cohesion split ofSpellAuras.cpp(12,928 → 6,069 lines) with no behaviour change. The 151Aura::HandleXxx/SpellAuraHolderhandlers move to 8 dedicated TUs:SpellAuraDummy·SpellAuraControl(carries the staticfrozenAuraTypestable) ·SpellAuraMisc·SpellAuraShapeshift·SpellAuraPeriodic·SpellAuraTrailing·SpellAuraLate·SpellAuraAddModifier.SpellAuras.huntouched; aura-holder lifecycle +ApplyModifierdispatch stay inSpellAuras.cpp. CMakefile(GLOB)auto-compiles the new TUs. Verbatim move, no dropped/duplicated defs. Builds clean (MSVC 2022, Release).This change is