Skip to content

Bots: More reliable cc range approach #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billy1arm merged 1 commit into from
Jul 23, 2026
+16 −2
Merged

Bots: More reliable cc range approach #456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/modules/Bots/playerbot/strategy/actions/CcActions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,17 @@ bool CastCcOnMyTargetAction::Execute(Event event)
return true;
}

float range = AI_VALUE2(float, "spell range", ccSpell);
if (bot->GetDistance(target) > range || bot->IsNonMeleeSpellCasted(false))
if (bot->IsNonMeleeSpellCasted(false))
{
return true;
}

float range = AI_VALUE2(float, "spell range", ccSpell);
if (bot->GetDistance(target) > range)
{
return MoveTo(target, range);
}

uint32 spellId = AI_VALUE2(uint32, "spell id", ccSpell);
if (!spellId)
{
Expand All @@ -191,6 +196,15 @@ bool CastCcOnMyTargetAction::Execute(Event event)
return true;
}

SpellEntry const* spellInfo = sSpellStore.LookupEntry(spellId);
if (spellInfo && bot->GetShapeshiftForm() != FORM_NONE)
{
if (GetErrorAtShapeshiftedCast(spellInfo, bot->GetShapeshiftForm()) == SPELL_FAILED_NOT_SHAPESHIFT)
{
ai->RemoveShapeshift();
}
}

ai->CastSpell(spellId, target);
m_lastCastAttempt = time(0);

Expand Down
Loading