Fix extra coordinate when creating polygons#958
Merged
AndrewSepic merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
chriswhong
approved these changes
Apr 1, 2026
Contributor
chriswhong
left a comment
chriswhong
left a comment
There was a problem hiding this comment.
LGTM, works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when creating polygons and terminating the drawing with a double click. Previously when closing the polygon with a doubleclick there was an additional duplicate coordinate created. ie: a 4 sided polygon had 6 coordinates instead of 5.
This fixes the extra coordinate, properly handling how browsers register clicks. When double clicking on the Map 3 points are actually created, therefore the
splice()method needed to remove an additional point. Theline.tshandler (which works as expected) already follows this pattern.