Skip to content

Conversation

@adrian-cojocaru
Copy link
Collaborator

Follow-up to #3979.

VectorTile class has a TileLoader member that goes out of scope in the base class, after ~VectorMVTTile / ~VectorMLTTile is called and can still handle requests before its parent gets destroyed. Incoming requests in this time frame resolve loadData calls to it's pure virtual definition.

  • This PR enforces the TileLoader destruction in the derived classes
  • Since the object is being destroyed (tile was marked as obsolete), an alternative fix is to change VectorTile::loadData to an empty implementation and ignore the response data.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +57.8Ki  +0.0% +12.9Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3996-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +47% +54.9Mi  +451% +26.9Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3996-compared-to-legacy.txt

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +1.74Ki  +0.1% +16.0Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3996-compared-to-main.txt

@adrian-cojocaru adrian-cojocaru marked this pull request as ready for review December 9, 2025 14:33
@adrian-cojocaru adrian-cojocaru enabled auto-merge (squash) December 9, 2025 16:54
@adrian-cojocaru adrian-cojocaru merged commit 52b8911 into maplibre:main Dec 9, 2025
46 of 47 checks passed
louwers pushed a commit to louwers/maplibre-native that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants