Allow global state expressions in layer visibility

[melitele]

• [Design Proposal] Allow global state expressions in layer visibility #1364

Launch Checklist

• Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
• Briefly describe the changes in this PR.
• Link to related issues.
• Write tests for all new functionality.
• Document any changes to public APIs.
• Add an entry to CHANGELOG.md under the ## main section.

[HarelM]

Is this considered a style spec change?
Cc: @louwers

[louwers]

Native doesn't support this yet so as far as Native is concerned changes are not a problem.

[HarelM]

There should probably a design proposal issue instead of this PR to discuss this, but as far as I understand this change, it might mean that every feature can change the visibility of a layer?
If so, it's problematic.
This is not a minor change to the spec to change how visibility is behaving, so I think a proper discussion (design proposal issue) is needed here.

[melitele]

... every feature can change the visibility of a layer?

Of course not, this is what filters are for.

This PR makes visibility dependent only on global state as per #6495

[hiddewie]

I wrote a design proposal in #1364

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.76%. Comparing base (ec30d56) to head (f4d4007).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1359      +/-   ##
==========================================
+ Coverage   93.73%   93.76%   +0.03%     
==========================================
  Files         111      112       +1     
  Lines        4626     4654      +28     
  Branches     1557     1565       +8     
==========================================
+ Hits         4336     4364      +28     
  Misses        290      290              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[HarelM]

Looks good in general, added a minor comment related to tests.
Also check out the coverage report, it's a bit "off".

[melitele]

... Also check out the coverage report, it's a bit "off".

wrong file extension - fixed now

[melitele]

@HarelM I incidentally deleted one of your review comments about making VisiblityExpression a class, sorry.

[HarelM]

Thanks! This looks great now.
Can you fix the lint warning about tsdocs?
Once fixed I'll merge this.

[melitele]

Can you fix the lint warning about tsdocs?

done 7b0678b

[hiddewie]

Thanks both for the effort implementing this 🎉!