chore(logging): runtime-reconfigurable trace configuration #1998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is like the previous PR a version of
tracingmartin-tracing-utilsfor configuring tracing (1/3) #1747So by now we have had
Honestly, I still like the extra crate more.
Much more readad and extendable in the future.
The runtime reconfiguration of formatting options is tricky as I need to get around some compiler limtations.
Changing the log level the same way is sadly not as simple, this is where I am hitting the
'static-requring brick wall.There are also some heavy tricks to allow for runtime recajigling of the log format (see the
boxingand the reload layer).I suspect that there is at least a bit of performance impact of all this work. Likely not enoguh to make a difference anyhow.
Before I do this work, shoud we go back to #1747 as a more reasonable approach?