MD-2882: Modified hive change metadata scripts#403
Open
prasadns14 wants to merge 1 commit intomapr:masterfrom
Open
MD-2882: Modified hive change metadata scripts#403prasadns14 wants to merge 1 commit intomapr:masterfrom
prasadns14 wants to merge 1 commit intomapr:masterfrom
Conversation
Contributor
|
Hey Prasad, can you please split this into 2 PRs - one for the TPC-DS script changes and one for the change metadata baseline changes? |
prasadns14
force-pushed
the
apply-2954
branch
from
54b4d1a to
68f3f6b
Compare
Contributor
Author
|
@agirish, done |
agirish
reviewed
Jan 11, 2018
| date_col int, | ||
| time_col bigint, | ||
| date_col date, | ||
| time_col string, |
Contributor
There was a problem hiding this comment.
Just curious - why "string"?
agirish
reviewed
Jan 11, 2018
| float_col int, | ||
| double_col float, | ||
| bool_col int | ||
| interval_col string, |
prasadns14
changed the title
Contributor
|
Hey Prasad, is this PR still needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@agirish, please review