Add Hobbies page, fix CI, and portfolio improvements#2
Merged
Conversation
Hobbies page (/hobbies): - Books tab: 20 books with 1–10 ratings, reviews, Open Library covers, and dual filter by year (2022–2025) and genre (Classic, Sci-Fi, etc.) - Travel tab: photo gallery structure ready for holiday photos; add trips to wwwroot/data/hobbies-photos.json and images to wwwroot/images/hobbies/ - /books redirects to /hobbies for any existing bookmarks - Nav updated: Books → Hobbies CI fix: - dotnet publish now targets MyPortfolio.csproj explicitly to prevent the test project being included in the publish step - Test project package versions pinned to confirmed-stable releases (xunit 2.9.0, Microsoft.NET.Test.Sdk 17.11.1) and marked IsPublishable=false https://claude.ai/code/session_01Qj49iUs6QNA2MQcCVP5cFN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/hobbies) — tabbed page with a Reading section (20 books, ratings, reviews, genre/year filters, Open Library covers) and a Travel section (photo gallery scaffolded and ready for holiday photos viawwwroot/data/hobbies-photos.json)dotnet publishnow targetsMyPortfolio.csprojexplicitly so the test project no longer breaks the publish step; test packages pinned to stable versions and markedIsPublishable=falseGitHubServicenow reads an optionalGitHub__Tokenenv var to raise the API rate limit from 60 to 5,000 req/hrEmail__GmailAddress/Email__GmailPasswordenv var names (ASP.NET Core__convention) so the contact form actually sendsog:imageupdated to profile photo;twitter:cardupgraded tosummary_large_imageMyPortfolio.Testsproject with 13 tests coveringGitHubServiceandF1ServiceAdding travel photos
Drop images into
wwwroot/images/hobbies/and add entries towwwroot/data/hobbies-photos.json:{ "trips": [ { "title": "Portugal 2025", "year": 2025, "description": "Two weeks in Lisbon and the Algarve", "photos": [ { "src": "/images/hobbies/portugal/lisbon.jpg", "caption": "Alfama at sunset", "location": "Lisbon" } ] } ] }Generated by Claude Code