Skip to content

Add Hobbies page, fix CI, and portfolio improvements#2

Merged
marksmith1994 merged 1 commit into
masterfrom
claude/add-claude-documentation-MabfT
May 20, 2026
Merged

Add Hobbies page, fix CI, and portfolio improvements#2
marksmith1994 merged 1 commit into
masterfrom
claude/add-claude-documentation-MabfT

Conversation

@marksmith1994

Copy link
Copy Markdown
Owner

Summary

  • Hobbies page (/hobbies) — tabbed page with a Reading section (20 books, ratings, reviews, genre/year filters, Open Library covers) and a Travel section (photo gallery scaffolded and ready for holiday photos via wwwroot/data/hobbies-photos.json)
  • CI fixdotnet publish now targets MyPortfolio.csproj explicitly so the test project no longer breaks the publish step; test packages pinned to stable versions and marked IsPublishable=false
  • GitHub token supportGitHubService now reads an optional GitHub__Token env var to raise the API rate limit from 60 to 5,000 req/hr
  • Email config fix — README and CLAUDE.md now document the correct Email__GmailAddress / Email__GmailPassword env var names (ASP.NET Core __ convention) so the contact form actually sends
  • OpenGraphog:image updated to profile photo; twitter:card upgraded to summary_large_image
  • PR build check — GitHub Actions now runs a build-only job on pull requests (no deploy)
  • Unit testsMyPortfolio.Tests project with 13 tests covering GitHubService and F1Service
  • CLAUDE.md — codebase documentation for AI assistants

Adding travel photos

Drop images into wwwroot/images/hobbies/ and add entries to wwwroot/data/hobbies-photos.json:

{
  "trips": [
    {
      "title": "Portugal 2025",
      "year": 2025,
      "description": "Two weeks in Lisbon and the Algarve",
      "photos": [
        { "src": "/images/hobbies/portugal/lisbon.jpg", "caption": "Alfama at sunset", "location": "Lisbon" }
      ]
    }
  ]
}

Generated by Claude Code

Hobbies page (/hobbies):
- Books tab: 20 books with 1–10 ratings, reviews, Open Library covers,
  and dual filter by year (2022–2025) and genre (Classic, Sci-Fi, etc.)
- Travel tab: photo gallery structure ready for holiday photos; add trips
  to wwwroot/data/hobbies-photos.json and images to wwwroot/images/hobbies/
- /books redirects to /hobbies for any existing bookmarks
- Nav updated: Books → Hobbies

CI fix:
- dotnet publish now targets MyPortfolio.csproj explicitly to prevent
  the test project being included in the publish step
- Test project package versions pinned to confirmed-stable releases
  (xunit 2.9.0, Microsoft.NET.Test.Sdk 17.11.1) and marked IsPublishable=false

https://claude.ai/code/session_01Qj49iUs6QNA2MQcCVP5cFN
@marksmith1994
marksmith1994 merged commit 3a8ee52 into master May 20, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants