Add the possibility to wrap the stack view within the superview's layout margins#36
Open
alexbredy wants to merge 6 commits intomarlimox:masterfrom
Open
Add the possibility to wrap the stack view within the superview's layout margins#36alexbredy wants to merge 6 commits intomarlimox:masterfrom
alexbredy wants to merge 6 commits intomarlimox:masterfrom
Conversation
|
This's really useful request. Could anyone with write access review it? |
yanamura
reviewed
Jun 3, 2019
Co-Authored-By: Yasuharu Yanamura <yanamura3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to AloeStackView to adapt its insets to the superview's layout margins.
Motivations:
An example ViewController has been added to showcase this. The screenshot below comes from that VC. The default insets are set to 0. The existing margin is the one that the superview defines.
Most of the lines in this PR are related to the example. The actual trick is done by overriding the
preservesSuperviewLayoutMarginsproperty of AloeStackView/UIScrollView.