Changes for a proper work of Upstream SOCKS5 with docker-compose (eg. WARP outbound).#187
Open
dreawer wants to merge 2 commits into
Open
Changes for a proper work of Upstream SOCKS5 with docker-compose (eg. WARP outbound).#187dreawer wants to merge 2 commits into
dreawer wants to merge 2 commits into
Conversation
Changes for a proper work of Upstream SOCKS5 (eg. WARP outbound).
Changes for a proper work of Upstream SOCKS5 with docker-compose (eg. WARP outbound).
dreawer
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the provided docker-compose examples to run the container with host networking, aiming to make upstream SOCKS5 chaining work reliably in Docker Compose setups (e.g., WARP outbound scenarios).
Changes:
- Switched the README docker-compose example from explicit
ports:mapping tonetwork_mode: host. - Switched
docker/docker-compose.ymlfrom explicitports:mapping tonetwork_mode: host.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.MD | Updates the documented docker-compose example to use host networking instead of port publishing. |
| docker/docker-compose.yml | Updates the sample compose file to use host networking instead of port publishing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ports: | ||
| - "53:53/tcp" | ||
| - "53:53/udp" | ||
| network_mode: host |
| ports: | ||
| - "53:53/tcp" | ||
| - "53:53/udp" | ||
| network_mode: host |
Author
There was a problem hiding this comment.
Hey, Copilot, try to make it work this way (with extra host and ports). It will not, i tried. The only way i was able to set the setvice work in docker-compose with WARP outbound is to set network_mode: host. Also i realy doubt this can cause any security issues.
| ports: | ||
| - "53:53/tcp" | ||
| - "53:53/udp" | ||
| network_mode: host |
Comment on lines
319
to
+320
| - ./data:/data | ||
| ports: | ||
| - "53:53/tcp" | ||
| - "53:53/udp" | ||
| network_mode: host |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for a proper work of Upstream SOCKS5 with docker-compose (eg. WARP outbound).