refactor(SOF-8040): take the Jupyter URLs as props - #11
Open
VsevolodX wants to merge 4 commits into
Open
Conversation
VsevolodX
force-pushed
the
feature/SOF-8040
branch
from
August 29, 2026 01:57
7787fa2 to
0800370
Compare
…lease] @mat3ra/ide, @mat3ra/made and @mat3ra/mode were pinned to wip release tarballs that cleanup-wip-releases.yml has since deleted, so `npm install` 404s and CI cannot reach the test step on any branch, main included. None of the three is imported by ave's source. Repinned to the latest published versions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
VsevolodX
force-pushed
the
feature/SOF-8040
branch
from
September 1, 2026 03:04
0800370 to
493f156
Compare
| return jobProperties.find((p) => { | ||
| return ( | ||
| p.source.info.jobId === ctx.jobId && | ||
| (!ctx.jobId || p.source.info.jobId === ctx.jobId) && |
Member
There was a problem hiding this comment.
Can we remove handling jobId here and just pass the notebookURL directly? The job logic should be in jode, jove, job-designer - one of those
The viewer no longer digs the jupyter_notebook_endpoint property out of jobProperties: the notebook and lab URLs arrive as jupyterNotebookUrl / jupyterLabUrl, built upstream by @mat3ra/jode's getJupyterEndpointUrls and threaded through job-designer -> workflow-designer -> wove. isJupyterExecutionUnit stays: which unit is a Jupyter unit is unit logic. The resolver, finder and URL builders move to jode; their tests move with them.
VsevolodX
force-pushed
the
feature/SOF-8040
branch
from
September 2, 2026 19:20
493f156 to
6fed460
Compare
This was referenced Sep 2, 2026
Open
VsevolodX
changed the title
Review: two flat string props let one arrive without the other — a state the resolver this replaced made impossible; the property row type was a third hand-written copy of a shape esse already owns; and nothing said why the Jupyter path takes props while Charts still digs job properties.
VsevolodX
commented
Sep 6, 2026
| onOutputUpdateRequest, | ||
| jobProperties, | ||
| jobId, | ||
| jupyterUrls, |
Member
Author
There was a problem hiding this comment.
Should be convergenceTabs or some other generic param, not specific to any application
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the dead Notebook/Lab tabs for SOF-8040, reworked per review: the viewer no longer handles
jobIdor digs through job properties — it receives finished URLs.ExecutionUnitViewer—jupyterNotebookUrl?/jupyterLabUrl?propsjupyter_notebook_endpointproperty (mat3ra/jode#6), job-designer maps them per unit (mat3ra/job-designer#23), workflow-designer/wove thread them down (mat3ra/workflow-designer#18, mat3ra/wove#17).utils/jupyterExecutionUnit.ts— resolver/finder/URL builders deleted@mat3ra/jode.isJupyterExecutionUnitstays:executable.name === "jupyter"is unit logic. No importers outside ave existed.JobPropertyForMonitorsbecomes a local typegetMonitorsFromProperties(Charts) still needs the row shape. Charts' ownjobIdbug is a separate ticket.tests/jupyterUtils.tests.tsisJupyterExecutionUnitcases remain.package.jsonrepin commitnpm installwithout the repin.Net: +33 / −301.