feat: add md-carousel component #110
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { html, LitElement, css } from 'lit' | ||
|
|
||
| export class CarouselItem extends LitElement { | ||
| static properties = {} | ||
|
|
||
| constructor() { | ||
| super() | ||
| } | ||
|
Comment on lines
+4
to
+8
Contributor
There was a problem hiding this comment. The |
||
|
|
||
| render() { | ||
| return html` | ||
| <div role="listitem" class="item"> | ||
| <slot></slot> | ||
| </div> | ||
| ` | ||
| } | ||
|
|
||
| static styles = css` | ||
| :host { | ||
| display: block; | ||
| scroll-snap-align: start; | ||
| flex-shrink: 0; | ||
| } | ||
| .item { | ||
| display: block; | ||
| border-radius: var(--md-carousel-item-shape, 24px); | ||
| overflow: hidden; | ||
| } | ||
| ` | ||
| } | ||
|
|
||
| customElements.define('md-carousel-item', CarouselItem) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,41 @@ | ||||||||||
| import { html, LitElement, css } from 'lit' | ||||||||||
|
|
||||||||||
| export class Carousel extends LitElement { | ||||||||||
| static properties = {} | ||||||||||
|
|
||||||||||
| constructor() { | ||||||||||
| super() | ||||||||||
| } | ||||||||||
|
Comment on lines
+4
to
+8
Contributor
There was a problem hiding this comment. The empty constructor can be removed. Additionally, consider adding an static properties = {
/**
* The aria-label of the carousel.
*/
ariaLabel: {attribute: 'aria-label'},
};
ariaLabel = 'Carousel'; |
||||||||||
|
|
||||||||||
| render() { | ||||||||||
| return html` | ||||||||||
| <div class="carousel" role="list" aria-label="Carousel"> | ||||||||||
|
Contributor
There was a problem hiding this comment. Use the
Suggested change
|
||||||||||
| <slot></slot> | ||||||||||
| </div> | ||||||||||
| ` | ||||||||||
| } | ||||||||||
|
|
||||||||||
| static styles = css` | ||||||||||
| :host { | ||||||||||
| display: block; | ||||||||||
| } | ||||||||||
| .carousel { | ||||||||||
| display: flex; | ||||||||||
| overflow-x: auto; | ||||||||||
| scroll-snap-type: x mandatory; | ||||||||||
| scrollbar-width: none; /* Firefox */ | ||||||||||
| -ms-overflow-style: none; /* IE and Edge */ | ||||||||||
| gap: 8px; /* Optional gap */ | ||||||||||
| padding: 16px; | ||||||||||
|
Comment on lines
+28
to
+29
Contributor
There was a problem hiding this comment. Using hardcoded values for
Suggested change
|
||||||||||
| scroll-behavior: smooth; | ||||||||||
| } | ||||||||||
| .carousel::-webkit-scrollbar { | ||||||||||
| display: none; /* Chrome, Safari and Opera */ | ||||||||||
| } | ||||||||||
| ::slotted(*) { | ||||||||||
| scroll-snap-align: start; | ||||||||||
| } | ||||||||||
| ` | ||||||||||
| } | ||||||||||
|
|
||||||||||
| customElements.define('md-carousel', Carousel) | ||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The imports for the carousel component are currently interspersed with the button component imports (e.g., between
button.jsandfilled-tonal-button.js). It is recommended to group imports by component type to maintain a clean and organized structure. Consider moving these imports after the completebuttonsgroup.