Split benchmark changes out of #264

[jashook]

Expanded benchmarks, comparing memory map vs in memory. Benchmarked on apple m3.

Method	Mean	Error	StdDev	Gen0	Gen1	Allocated
CityMemoryMappedLookup	6.555 ms	0.0589 ms	0.0460 ms	468.7500	-	3.79 MB
CityMemoryLookup	2.154 ms	0.0171 ms	0.0143 ms	472.6563	3.9063	3.79 MB

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the existing benchmarking suite by introducing comprehensive comparisons between different MaxMind.Db.Reader file access modes: memory-mapped versus in-memory. It also evaluates the performance implications of implementing a caching mechanism for both access types. These additions provide valuable insights into the optimal configuration for database lookups, particularly on aarch64 architecture, as indicated by the benchmark results in the PR description.

Highlights

• Expanded Benchmarking Scenarios: Introduced new benchmark methods to compare MaxMind.Db.Reader performance using MemoryMapped and Memory file access modes.
• Caching Strategy Evaluation: Added benchmark variations to assess the impact of caching on both MemoryMapped and Memory access modes.
• Reader Initialization Updates: Modified the GlobalSetup method to initialize separate Reader instances for each new benchmark scenario, ensuring proper isolation and configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the CityBenchmark class to introduce new benchmark methods for different MaxMind.Db.Reader configurations, specifically testing memory-mapped and array-buffered file access modes, both with and without caching. Feedback indicates that the GlobalCleanup method should be updated to dispose of all initialized Reader instances to prevent resource leaks and ensure consistency. Additionally, an unnecessary null-conditional operator (?.) was identified in the CityMemoryCachedLookup benchmark, which should be removed for clarity and consistency with other benchmark methods.

[horgh]

Thanks for splitting it out! I had a minor comment but otherwise looks great!