Skip to content

Test iOS Device SDK against production / final tweaks#12

Merged
PatrickCroninMM merged 4 commits intomainfrom
pcronin/tweaks-before-launch
May 1, 2026
Merged

Test iOS Device SDK against production / final tweaks#12
PatrickCroninMM merged 4 commits intomainfrom
pcronin/tweaks-before-launch

Conversation

@PatrickCroninMM
Copy link
Copy Markdown
Contributor

This PR:

  • Updates the CI github build action to retry builds 3 times. In practice I've found the step pretty flaky, getting stuck when asking Xcode to build the project. A retry has always worked though, so I think it's reasonable to automate that process to minimize manual intervention.
  • Updates a platform name in the docs to one that exists in current Xcode versions (so that the example works as written).

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the xcodebuild destination in the README to use 'iPhone 17'. Feedback indicates that the PR description mentions CI workflow updates that are missing from the actual changes. Furthermore, the update introduces an inconsistency with other examples in the README that still reference 'iPhone 16'.

Comment thread README.md
@linear
Copy link
Copy Markdown

linear Bot commented Apr 30, 2026

SCO-8433 Test iOS Device SDK against production / final tweaks

A/C

  • We should make sure it works as expected in production before a client integrates it.
  • Since we may be pushing changes to the SDK, this would also be a good time to:
    • Make final repo tweaks
    • Add any release automation needed, but I suspect we're all set with README.dev.md
    • Add in auto-retries for the CI builds that routinely heisenfail

@PatrickCroninMM PatrickCroninMM force-pushed the pcronin/tweaks-before-launch branch 2 times, most recently from 34f8e71 to 1ce5b5a Compare April 30, 2026 19:04
@PatrickCroninMM PatrickCroninMM force-pushed the pcronin/tweaks-before-launch branch from 1ce5b5a to fe10f64 Compare April 30, 2026 19:05
@PatrickCroninMM PatrickCroninMM merged commit 56b1ad9 into main May 1, 2026
23 checks passed
@PatrickCroninMM PatrickCroninMM deleted the pcronin/tweaks-before-launch branch May 1, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant