Chore: Add logs to track longest backend calls perfomance - #685
Conversation
KaylaBrady
left a comment
KaylaBrady
left a comment
There was a problem hiding this comment.
👍 a few minor comments!
| fetch_schedules_and_combine_data(conn, stop_ids_concat, date_time_string, params) | ||
| end) | ||
|
|
||
| Logger.info( |
There was a problem hiding this comment.
question: Is this redundant to the log below? if not, maybe worth adding something unique to distinguish it from the other "schedules request" log
There was a problem hiding this comment.
I missed that, it actually is, let me remove it
| |> Enum.map_join(" ", fn {name, value} -> "#{name}=#{value}" end) | ||
|
|
||
| if stage_healthy and consumer_healthy do | ||
| Logger.info("#{__MODULE__} #{health_state}") |
There was a problem hiding this comment.
suggestion (non-blocking): this is a function that timed out in the past, so we have some signal that there might actually be performance issues here. It could be interesting to add duration to these existing logs & keep it at the info level to motivate whether to prioritize the linked ticket.
There was a problem hiding this comment.
Makes sense Iw as trying to remove a log that had a log events
2 participants
Summary
Ticket: re-assess backend stability
Testing