feat ✨ Access archive name from script

[mr-aboutin]

Export Archive name

Added the variable ARCHIVE_NAME to the makeself header to give the start script access not only to the archive directory but also it's name.

---

Note

Expose ARCHIVE_NAME (basename of the archive) to the start script and add tests validating it.

• Core:
  • Export ARCHIVE_NAME=\basename "$0"`inmakeself-header.sh` to expose the archive file name to the embedded script.
• Tests (test/variabletest):
  • Use ARCHIVE_NAME when creating the test archive.
  • Add testArchiveName to assert the exposed ARCHIVE_NAME matches the expected value.

^{Written by Cursor Bugbot for commit 8dc6b13. This will update automatically on new commits. Configure here.}

[Copilot]

Pull Request Overview

This PR adds the ability for embedded scripts in makeself archives to access the archive's filename through a new ARCHIVE_NAME environment variable.

• Exports ARCHIVE_NAME variable in the makeself header script containing the basename of the archive file
• Updates the test suite to use the new variable and validate its functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
makeself-header.sh	Adds ARCHIVE_NAME variable export using basename "$0"
test/variabletest	Updates test to use ARCHIVE_NAME variable and adds test case to validate it

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The test logic is incorrect. The variable ans represents a directory path with special characters, but the test is comparing actual_archive_name (which should be the archive filename) with ARCHIVE_NAME (which is 'makeself-test.run'). The ans variable and directory creation are unnecessary for testing the archive name functionality.

Suggested change

	local ans="${temp}"$'/complicated\n dir\twith spaces'
	mkdir -p "${ans}"
	cd "${ans}"
	actual_archive_name="$("${temp}/makeself-test.run" --quiet)"
	actual_archive_name="$("./makeself-test.run" --quiet)"

[megastep]

I like it - Copilot seems to have a point about the purpose of this test as this doesn't seem to be testing what is actually happening within the script. ARCHIVE_NAME here is set before running the scripts.

[mr-aboutin]

Of course, I could change the setup method to check for a second argument and, if passed, would use that has the filename, if that's okay with you. I didn't want to change too much of the tests so I based it on the existing ones but I scope the test better.

…

On Mon, Sep 29, 2025, 22:53 Stéphane Peter ***@***.***> wrote: ***@***.**** requested changes on this pull request. I like it - Copilot seems to have a point about the purpose of this test as this doesn't seem to be testing what is actually happening within the script. ARCHIVE_NAME here is set before running the scripts. — Reply to this email directly, view it on GitHub <#348 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQXK3GXAHZ2XJCZN5JFAEZD3VHWBFAVCNFSM6AAAAACH3BXZQSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTEOBSGQYDEOJZHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[megastep]

Looks good to me!