mtest: consider AttributeError#15445
Merged
dcbaker merged 1 commit intomesonbuild:masterfrom Jan 22, 2026
Merged
Conversation
eli-schwartz
reviewed
Jan 6, 2026
| except OSError: | ||
| except (OSError, AttributeError): | ||
| self.cols = 80 | ||
| self.is_tty = False |
Member
There was a problem hiding this comment.
Is it indeed accurate to say that OS/2 doesn't (cannot ever) have a tty?
Contributor
Author
There was a problem hiding this comment.
Error says that os does not have get_terminal_size attr. I know, os.get_terminal_size() has not been implemented on OS/2.
Contributor
There was a problem hiding this comment.
Would this work instead?
self.is_tty = os.isatty(1)
self.cols = 80
if self.is_tty:
try:
self.cols, _ = os.get_terminal_size(1)
except (OSError, AttributeError):
pass
Contributor
Author
There was a problem hiding this comment.
Yes, but parentheses are necessary.
Traceback (most recent call last):
File "f:/lang/work/meson/meson-os2.git/meson.py", line 27, in <module>
sys.exit(mesonmain.main())
File "f:\lang\work\meson\meson-os2.git/mesonbuild/mesonmain.py", line 313, in main
return run(sys.argv[1:], launcher)
File "f:\lang\work\meson\meson-os2.git/mesonbuild/mesonmain.py", line 304, in run
return CommandLineParser().run(args)
File "f:\lang\work\meson\meson-os2.git/mesonbuild/mesonmain.py", line 67, in __init__
from . import mconf, mdist, minit, minstall, mintro, msetup, mtest, rewriter, msubprojects, munstable_coredata, mcompile, mdevenv, mformat
File "f:\lang\work\meson\meson-os2.git/mesonbuild/mtest.py", line 562
except OSError, AttributeError:
^
SyntaxError: invalid syntax
Contributor
Author
There was a problem hiding this comment.
And the following error ocurrs:
[0/1] Running all tests
Traceback (most recent call last):
File "f:\lang\work\meson\meson-os2.git/mesonbuild/mesonmain.py", line 193, in run
return options.run_func(options)
File "f:\lang\work\meson\meson-os2.git/mesonbuild/mtest.py", line 2308, in run
with TestHarness(options) as th:
File "f:\lang\work\meson\meson-os2.git/mesonbuild/mtest.py", line 1674, in __init__
self.console_logger = ConsoleLogger(options.max_lines)
File "f:\lang\work\meson\meson-os2.git/mesonbuild/mtest.py", line 565, in __init__
self.output_start = dashes(self.SCISSORS, self.HLINE, self.cols - 2)
AttributeError: 'ConsoleLogger' object has no attribute 'cols'
ERROR: Unhandled python exception
This is a Meson bug and should be reported!
Member
There was a problem hiding this comment.
Would this work instead?
Then there is no need to check for OSError either... OSError is how os.get_terminal_size(1) signals that fd 1 isn't a tty.
Contributor
Author
There was a problem hiding this comment.
Without OSError check, PowerShell tests failed. So I added it again.
os.get_terminal_size is not defined on OS/2.
bonzini
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.get_terminal_size is not defined on OS/2.