fix: Improve error catching in entity loader #1197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When any database error is thrown in the entity loader, the actual error message is hidden and replaced with a generic "not found" error as the code seems to assume any error should be a notfound. Check the type of error and return an actual error message in all other cases so we can actually debug what is happening.
This would be helpful for debuggijng, end-users can report an error message and not just "it says 500 an unhandled error occurred".
catching errors the right way, and small refactor to remove the eslint-disable rules that shouldn't be there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When any database error is thrown in the entity loader, the actual error message is hidden and replaced with a generic "not found" error as the code seems to assume any error should be a notfound. Check the type of error for specific NotFoundError from the ORM model, and return a 500 with the actual error message in all other cases so we can actually debug what is happening.
Before, generic 404 error when it's actually a database error:
After, show the actual error:
Yes, the UI could definitely be improved (the whole error is now in the title instead of having a detailedMessage), but this is for another PR.