Skip to content

Add GROMACS simulation engine#130

Open
PicoCentauri wants to merge 5 commits intomainfrom
gromacs
Open

Add GROMACS simulation engine#130
PicoCentauri wants to merge 5 commits intomainfrom
gromacs

Conversation

@PicoCentauri
Copy link
Contributor

@PicoCentauri PicoCentauri commented Dec 10, 2025

Added installation instructions for the GROMACS engine.

Contributor (creator of pull-request) checklist

- [ ] Tests updated (for new features and bugfixes)?

  • Documentation updated (for new features)?
    - [ ] Issue referenced (for PRs that solve an issue)?

Reviewer checklist

  • CHANGELOG updated with public API or any other important changes?

📚 Download documentation for this pull-request

Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @PicoCentauri

@PicoCentauri
Copy link
Contributor Author

We have to add the recent changes like variants before we release

@HaoZeke
Copy link
Member

HaoZeke commented Jan 31, 2026

We have to add the recent changes like variants before we release

Yup and get these on the channel
https://github.com/metatensor/gromacs-metatomic-feedstock/tree/main

(would be OK being a recipe maintainer BTW?)

@PicoCentauri
Copy link
Contributor Author

Yes sure.

PicoCentauri and others added 3 commits February 2, 2026 11:39
Co-authored-by: Guillaume Fraux <guillaume.fraux@epfl.ch>
@PicoCentauri PicoCentauri marked this pull request as ready for review March 18, 2026 13:48
@PicoCentauri PicoCentauri requested a review from Luthaf March 18, 2026 14:46
cmake .. \
-DCMAKE_PREFIX_PATH="$CMAKE_PREFIX_PATH" \
-DTorch_DIR=$TORCH_PREFIX \
-DGMX_METATOMIC=AUTO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this AUTO and not ON?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parity with nnpot

Below is a example input file for an ML/MM simulation of an alanin dipeptide in water,
using a metatomic model for the peptide and a classical force field for the water
molecules. For a detailed example we refer to the `chapter in the atomistic cookbook
<TODO>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait for this before we merge here?

on a subgroup (ML/MM) with interatomic potentials in the metatomic format.

How to install the code
^^^^^^^^^^^^^^^^^^^^^^^
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a section on how to get the code from conda, and how to pick the correct build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes same as for lammps. I will ad tomorrow

@PicoCentauri PicoCentauri requested a review from Luthaf March 20, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants