Learn the ventilation unit node id from CnNodeNotification - #79
Merged
Conversation
On newer firmware the ventilation unit is no longer exposed as node 1, so every RMI request returned RMI_ERROR while the session itself established fine. A ComfoAir Flex was for example seen at node 45. Handle CnNodeNotificationType instead of ignoring it, and keep track of the nodes on the ComfoNet bus per session. The node whose productId identifies a ventilation unit (1 = ComfoAirQ, 8 = ComfoAirFlex) is the node all RMI and property calls are sent to. Other nodes on the bus, such as the gateway (5) and the Flex connection board (9), are stored but never selected. The nodes are announced when a session starts, and we also send a CnNodeRequest to retrigger the discovery. We wait for the ventilation unit before the session is considered ready, so the first property read already goes to the right node. There is no fallback to node 1: when the bridge doesn't announce a ventilation unit, a VentilationUnitNotFoundException is raised instead of sending commands to a node that we are only guessing about. The reconnect loop retries every 5 seconds, so connect() fails with its usual timeout. Fixes #78 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 2, 2026
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On newer firmware the ventilation unit is no longer exposed as node 1, so every RMI/property call returned
RMI_ERRORwhile the session itself established fine (a ComfoAir Flex was seen at node 45).This handles
CnNodeNotificationTypeinstead of ignoring it and tracks the nodes on the ComfoNet bus per session. The node whoseproductIdidentifies a ventilation unit (1= ComfoAirQ,8= ComfoAirFlex) is the node all RMI/property calls are sent to; other nodes (gateway5, Flex connection board9, …) are stored but never selected. ACnNodeRequestretriggers discovery, and the session isn't reported ready until the unit is known.There is deliberately no fallback to node 1: when the bridge doesn't announce a ventilation unit, a
VentilationUnitNotFoundExceptionis raised instead of sending commands to a guessed node. The reconnect loop retries every 5 seconds, soconnect()fails with its usual timeout.Testing
get-propertyCLI all work; an explicit wrong node still yieldsRMI_ERROR.VentilationUnitNotFoundExceptionraised).Fixes #78