Draft
Conversation
Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix build failure on VS 2022 and VS 2026
Use Ninja generator for gcc and clang presets
Feb 3, 2026
carsonRadtke
reviewed
Feb 3, 2026
carsonRadtke
reviewed
Feb 4, 2026
CMakePresets.json
Outdated
Contributor
Author
There was a problem hiding this comment.
This was already changed to "Ninja" in commit 06dd56d (the previous commit in this PR).
Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com>
Copilot
AI
changed the title
Use Ninja generator for gcc and clang presets
Use Ninja generator for all CMake presets
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMake presets used inconsistent generators which caused build failures on Windows (VS 2022/2026). The
gcc-baseandclang-basepresets used "Unix Makefiles" which fails on Windows withCMake was unable to find a build program corresponding to "Unix Makefiles". Themsvc-basepreset used "Visual Studio 17 2022" which is Windows-specific.Changes
gcc-baseandclang-basepresetsmsvc-basepresettoolsetandarchitecturefields frommsvc-basepreset{ "name": "msvc-base", "inherits": "base", "hidden": true, - "generator": "Visual Studio 17 2022", + "generator": "Ninja", "condition": { "type": "equals", "lhs": "${hostSystemName}", "rhs": "Windows" }, - "toolset": "host=x64", - "architecture": "x64", "cacheVariables": { "CMAKE_CXX_COMPILER": "cl" } }This ensures consistent, fast builds across all platforms and compilers.
Original prompt
This section details on the original issue you should resolve
<issue_title>Since c31617f build fails on VS 2022 and VS 2026</issue_title>
<issue_description>Describe the bug
The build of the test fails.