Skip to content

Harden telemetry delivery and refine recipe metadata#2443

Open
bmehta001 wants to merge 81 commits into
mainfrom
bhamehta/fix-telemetry-deadlock
Open

Harden telemetry delivery and refine recipe metadata#2443
bmehta001 wants to merge 81 commits into
mainfrom
bhamehta/fix-telemetry-deadlock

Conversation

@bmehta001

@bmehta001 bmehta001 commented May 5, 2026

Copy link
Copy Markdown
Contributor

Same-repository replacement for #2441 so Azure CI runs with the normal microsoft/Olive PR secret context.

Summary

  • harden Olive telemetry delivery and cache behavior for non-CI runs, including Windows file locking, cache-path handling, and unreadable flush preservation
  • keep CI telemetry ephemeral: CI emits only OliveRecipe and does not register local cache callbacks
  • prevent Docker workflows from double-counting OliveRecipe by suppressing the inner container recipe event and forwarding CI detection into workflow containers
  • refine OliveRecipe metadata so target fields are emitted only for explicit targets, host fields are tracked separately, and recipe/config telemetry captures redacted explicit overrides
  • replace opaque package-config hashing with redacted package_config_overrides, while keeping package_config out of recipe_hash
  • make recipe source/hash metadata deterministic by avoiding filesystem-dependent model/resource classification
  • add or update focused telemetry, workflow, and Docker tests and refresh the privacy documentation

Why

We want telemetry to be reliable under cache contention and offline retry, while keeping CI runs temporal and recipe-only. We also want the recipe signal to be useful for analyzing explicit overrides without mixing host/target semantics, relying on opaque hashes, or depending on local filesystem state.

Validation

  • lintrunner f -a -m main
  • python -m compileall olive\\telemetry\\constants.py olive\\telemetry\\telemetry.py olive\\workflows\\run\\run.py olive\\systems\\docker\\docker_system.py test\\test_telemetry.py test\\workflows\\test_workflow_run.py test\\systems\\docker\\test_docker_system.py
  • pytest test\\test_telemetry.py test\\workflows\\test_workflow_run.py test\\systems\\docker\\test_docker_system.py -q
  • confirmed .azure_pipelines and .github do not set OLIVE_DISABLE_TELEMETRY, disable_telemetry, or --disable_telemetry

Copilot AI review requested due to automatic review settings May 5, 2026 02:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends Olive's telemetry pipeline so workflow runs emit a new OliveRecipe signal with redacted recipe metadata, while also tightening cache handling and documenting the updated telemetry behavior. It fits into the workflow, CLI, and telemetry layers that capture how Olive runs recipes across local and CI environments.

Changes:

  • Adds recipe-result telemetry from workflow execution and CLI entry points, including recipe hashes, model/source metadata, host/target metadata, and redacted config/package override snapshots.
  • Reworks telemetry delivery details, including cache-path overrides, JSON-line cache storage, Windows file locking, unreadable flush preservation, and CI recipe-only filtering.
  • Adds focused workflow and telemetry tests, plus privacy-documentation updates.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
test/workflows/test_workflow_run.py Adds coverage for recipe-result metadata emitted by workflow runs.
test/test_telemetry.py Adds tests for cache-path overrides, CI filtering, unreadable flush handling, and Windows file locking.
olive/workflows/run/run.py Builds and emits recipe telemetry metadata during workflow execution.
olive/telemetry/utils.py Reworks cross-platform exclusive file locking for telemetry cache access.
olive/telemetry/telemetry.py Adds OliveRecipe, CI filtering, and cache/flush behavior changes.
olive/telemetry/telemetry_extensions.py Adds a helper for logging recipe results.
olive/telemetry/library/telemetry_logger.py Adds locking around singleton logger setup and configurable service name.
olive/telemetry/library/options.py Extends exporter options with service_name.
olive/telemetry/constants.py Updates the encoded telemetry connection string.
olive/cli/run.py Passes workflow-run recipe metadata into telemetry.
olive/cli/base.py Passes generated-CLI recipe metadata from higher-level commands.
docs/Privacy.md Updates the privacy text for the new recipe telemetry behavior.

Comment thread olive/workflows/run/run.py Outdated
Comment thread olive/telemetry/telemetry.py Outdated
Comment thread olive/telemetry/telemetry.py
Comment thread olive/workflows/run/run.py Outdated
Comment thread olive/workflows/run/run.py Outdated
Comment thread docs/Privacy.md Outdated
@bmehta001 bmehta001 self-assigned this May 5, 2026
@bmehta001

Copy link
Copy Markdown
Contributor Author

/AzurePipelines help

@azure-pipelines

Copy link
Copy Markdown
Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@bmehta001

Copy link
Copy Markdown
Contributor Author

/AzurePipelines run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@bmehta001
bmehta001 force-pushed the bhamehta/fix-telemetry-deadlock branch from e47e0ce to befbb08 Compare May 9, 2026 03:47
@bmehta001
bmehta001 requested a review from shaahji May 11, 2026 18:15

@shaahji shaahji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Have you considered using a local db solution like sqllite3 or tinydb for storing data? These might have a lot of added benefits compared to holding information in a file on disk.
  • Olive config paths can contain pathlib.Path values. Default json package doesn't like these when invoked with calls to json.dump or json.dumps. You might want to check for those.

Comment thread olive/cli/run.py Outdated
Comment thread olive/telemetry/library/telemetry_logger.py Outdated
Comment thread olive/telemetry/library/telemetry_logger.py Outdated
Comment thread olive/telemetry/library/telemetry_logger.py Outdated
Comment thread olive/telemetry/telemetry.py Outdated
Comment thread olive/telemetry/utils.py Outdated
Comment thread olive/telemetry/recipe_telemetry.py
Comment thread olive/telemetry/recipe_telemetry.py
Comment thread olive/telemetry/recipe_telemetry.py
Comment thread olive/telemetry/recipe_telemetry.py Outdated
@bmehta001
bmehta001 force-pushed the bhamehta/fix-telemetry-deadlock branch from f8d1701 to 4a91dda Compare May 22, 2026 15:00
bmehta001 added a commit that referenced this pull request May 26, 2026
Address review findings on PR #2443:

- Track per-flush replay failures so the flush file is preserved when any replayed event was rejected, instead of being silently deleted alongside the cached events.

- Remove the unreachable OSError retry/backoff in _write_payload_to_cache: the exclusive file lock is blocking, so the retry tier never fired.

- Replace the polling shutdown wait with a condition-variable wait_until_flush_complete helper and notify_all when _is_flushing clears.

- Add focused tests covering replay success deletes the flush file, replay failure restores it, callback timeout restores it, and the new wait helper wakes on notify and honors its timeout.

Files changed:
- olive/telemetry/telemetry.py
- test/test_telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bmehta001 and others added 17 commits June 10, 2026 23:04
Replace separate _lock and _callback_condition with a single
_condition (threading.Condition) that protects all shared state:
_shutdown, _is_flushing, _callbacks_item_count, _events_logged.

The two-lock design had a lock order inversion: on_payload_transmitted
acquired _lock then _callback_condition, while wait_for_callbacks
acquired _callback_condition then _lock (via is_flushing). This could
deadlock under concurrent flush + callback scenarios.

Using one lock eliminates the ordering issue entirely and simplifies
the code — the on_payload_transmitted callback no longer needs nested
lock acquisition.

Files changed:
- olive/telemetry/telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wait_for_callbacks: Hold _condition lock continuously from condition
check through wait() to prevent missing notifications. Previously the
lock was released between checking and waiting, allowing notify_all()
to fire in the gap.

TelemetryLogger: Add RLock to __new__ and get_default_logger to
prevent race conditions when multiple threads create the singleton
simultaneously. Uses RLock because get_default_logger calls __new__
which both need the same lock.

Files changed:
- olive/telemetry/telemetry.py
- olive/telemetry/library/telemetry_logger.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1. Remove base64 encoding from cache: write raw JSON lines instead.
   The base64 layer added 33% size overhead and prevented human
   inspection during debugging with no security benefit (cache dir
   is user-owned). Cache file is now directly readable.

2. Simplify cache flush: remove the .flush file rename dance
   (atomic rename, restore on failure, stale file cleanup). For ~5
   events/session, simple lock-read-send-delete is sufficient. On
   failure the cache file persists for next retry.

3. Simplify Telemetry singleton: remove double-checked locking in
   __new__. The lock is cheap and called once at startup; the outer
   check saved a lock acquisition but added complexity.

Net: -83 lines.

Files changed:
- olive/telemetry/telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix 1: Remove duplicate callback count increment in
on_payload_transmitted when _is_flushing is true. The count was
incremented both in the early-return path and in the finally block,
causing wait_for_callbacks to think events completed before they
actually did. Now only the finally block increments (which always
runs, even on return).

Fix 2: Replace flush_path.replace(cache_path) with new
_restore_flush_file() method that appends flush entries into the
cache file instead of overwriting it. This prevents losing events
written by another process while a flush was in progress.

Files changed:
- olive/telemetry/telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Emit a single OliveRecipe event per workflow so recipe usage and failures can be measured without double-counting nested action failures. Keep CI in recipe-only mode, make Olive app naming explicit, update the telemetry ingestion key, and harden the cache/locking path that the new telemetry depends on.

Files changed:
- docs/Privacy.md
- olive/cli/base.py
- olive/cli/run.py
- olive/telemetry/constants.py
- olive/telemetry/library/options.py
- olive/telemetry/library/telemetry_logger.py
- olive/telemetry/telemetry.py
- olive/telemetry/telemetry_extensions.py
- olive/telemetry/utils.py
- olive/workflows/run/run.py
- test/test_telemetry.py
- test/workflows/test_workflow_run.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace optional runtime imports with importlib-based lookups so the recent telemetry changes stay lint-clean without adding new noqa markers. Keep the focused telemetry tests import-sorted and ready for CI.

Files changed:
- olive/cli/base.py
- olive/workflows/run/run.py
- test/test_telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep exporter options focused on transport/export concerns and move service.name defaults into the logger/resource layer where they belong. This keeps Olive's explicit app name override separate from the shared logger fallback and removes unnecessary plumbing.

Files changed:
- olive/telemetry/library/options.py
- olive/telemetry/library/telemetry_logger.py
- test/test_telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep Olive''s explicit service-name override in the logger path, but restore the previous shared-library fallback and compatibility behavior so this cleanup does not broaden unrelated API or default changes.

Files changed:
- olive/telemetry/library/options.py
- olive/telemetry/library/telemetry_logger.py
- test/test_telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Trim the branch back to telemetry behavior and the minimal plumbing needed to support it. Restore the original local-import patterns in CLI and workflow code, keep only targeted lint suppressions where those restored lines are required, and simplify the telemetry logger app-name plumbing without changing the feature behavior.

Files changed:
- olive/cli/base.py
- olive/cli/run.py
- olive/telemetry/library/telemetry_logger.py
- olive/workflows/run/run.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix the correctness and security issues raised on PR #2441 by handling empty telemetry cache-dir overrides safely, preserving non-empty unreadable flush files instead of deleting them, restoring the legacy .json.flush naming pattern, handling non-pathlike recipe config inputs without masking the original error, and cleaning up the Windows ctypes import pattern for CodeQL.

Files changed:
- olive/telemetry/telemetry.py
- olive/telemetry/utils.py
- olive/workflows/run/run.py
- test/test_telemetry.py
- test/workflows/test_workflow_run.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Drop the explicit service.name wiring test from test/test_telemetry.py since it is mostly implementation-detail coverage and does not protect the higher-value telemetry behavior changes on this branch.

Files changed:
- test/test_telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Resolve the remaining github-advanced-security findings by removing unused PLC0415 noqa markers, keeping the optional-import behavior via minimal import cleanup, and updating the telemetry tests to satisfy the protected-access and consider-using-with lint comments without changing the tested behavior.

Files changed:
- olive/cli/base.py
- olive/cli/run.py
- olive/workflows/run/run.py
- test/test_telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove dead base64 cache helpers from olive/telemetry/utils.py and move exception formatting next to the telemetry extension code that actually uses it. Keep the Win32 locking and cache-dir logic intact while reducing unrelated utility clutter.

Files changed:
- olive/telemetry/utils.py
- olive/telemetry/telemetry_extensions.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Compute the CI environment flag once during Telemetry initialization and reuse it for recipe-only gating and heartbeat suppression instead of calling the check twice back-to-back.

Files changed:
- olive/telemetry/telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep target telemetry fields only for explicitly configured targets, add separate host fields, remove the ambiguous input model name hash, and add redacted config-overrides plus package-config hash metadata so recipe telemetry can show which overrides users actually provide without folding environment-specific package config into recipe_hash.

Files changed:
- docs/Privacy.md
- olive/telemetry/telemetry.py
- olive/workflows/run/run.py
- test/workflows/test_workflow_run.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Log redacted package-config overrides instead of an opaque hash so Olive telemetry captures the specific package settings users changed, while still excluding package_config from recipe_hash and avoiding raw module-path leakage.

Files changed:
- docs/Privacy.md
- olive/telemetry/telemetry.py
- olive/workflows/run/run.py
- test/workflows/test_workflow_run.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Skip Hugging Face and Docker logins when PR secrets are unavailable or unresolved so Azure unit-test jobs do not fail before tests start on fork-style runs, while still preserving normal login behavior when valid credentials are present.

Files changed:
- .azure_pipelines/job_templates/build-docker-image-template.yaml
- .azure_pipelines/job_templates/huggingface-login-template.yaml
- .azure_pipelines/job_templates/olive-test-linux-gpu-template.yaml
- .azure_pipelines/scripts/run_test.sh

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Detect lowercase olive package path segments so installed frames retain a safe filename and line/function context without exposing directories.

Files changed:
- olive/telemetry/telemetry_extensions.py
- test/test_telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 29 changed files in this pull request and generated 1 comment.

Comment thread olive/cli/launcher.py Outdated
Port ORT's first-anchor-to-end [path] scrubber and 256-byte UTF-8 cap for Olive error telemetry while preserving traceback line and function context.

Files changed:
- olive/telemetry/telemetry_redaction.py
- olive/telemetry/telemetry_extensions.py
- test/test_telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 29 out of 30 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

olive/cli/launcher.py:87

  • The ORT_DISABLE_TELEMETRY environment variable is restored immediately after constructing Telemetry(), before the command actually runs. This means --disable_telemetry may not suppress downstream telemetry (e.g., ONNX Runtime) during service.run(), even though the flag name and privacy docs imply it should apply for the whole invocation. Consider keeping the env var set until after the command completes (and telemetry is shut down), then restoring it to avoid leaking into subsequent invocations in the same process.
        if disable_telemetry:
            if previous_opt_out is None:
                os.environ.pop("ORT_DISABLE_TELEMETRY", None)
            else:
                os.environ["ORT_DISABLE_TELEMETRY"] = previous_opt_out

Comment thread olive/telemetry/telemetry_extensions.py Outdated
Retain the invocation-scoped opt-out through command execution and telemetry shutdown so downstream ONNX Runtime honors the CLI flag, then restore the caller's environment.

Files changed:
- olive/cli/launcher.py
- test/cli/test_cli.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 29 out of 30 changed files in this pull request and generated no new comments.

Apply ORT-compatible redaction to nested action and error metadata so arbitrary context values cannot bypass path privacy controls.

Files changed:
- olive/telemetry/telemetry_extensions.py
- test/test_telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 29 out of 30 changed files in this pull request and generated 1 comment.

Comment thread olive/workflows/run/run.py

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 29 out of 30 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

olive/telemetry/telemetry.py:214

  • PR description says CI telemetry should be ephemeral, but the CI path still initializes a durable SQLite offline store under the normal per-user telemetry base directory. On hosted CI agents where the cache directory persists between jobs, this can carry over OliveRecipe rows across unrelated runs and defeat the “ephemeral CI” goal.

Consider making CI recipe-only telemetry truly ephemeral (e.g., bypass OfflineEventStore and POST directly, or use a per-run temp directory / delete the DB on shutdown) so CI never writes durable telemetry state to the shared cache location.

                # Durable on-disk queue + background uploader. The uploader
                # retries enabled-run events until delivery.
                db_path = os.path.join(get_telemetry_base_dir(), DB_FILE_NAME)
                self._store = OfflineEventStore(db_path)
                if not self._store.is_open:

Document that traceback filenames are replaced with [path] under the ORT-compatible scrubber.

Files changed:
- olive/telemetry/telemetry_extensions.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 29 out of 30 changed files in this pull request and generated no new comments.

Stringify dictionary keys before filtering so numeric and boolean keys survive serialization while only the empty string is skipped.

Files changed:
- olive/telemetry/library/serialization.py
- test/test_telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

olive/workflows/run/run.py:224

  • _build_recipe_result_metadata computes config_overrides from the run_config_telemetry_input parameter when the caller doesn’t explicitly provide overrides. Here run() always passes None, so recipe telemetry will never auto-capture redacted config overrides from a config file/dict (contrary to the intended behavior).
                metadata = _build_recipe_result_metadata(
                    run_config,
                    None,
                    parsed_run_config,
                    recipe_telemetry_metadata,

Comment thread olive/telemetry/telemetry.py Outdated
Apply ORT-compatible redaction to string keys as well as nested action and error metadata values.

Files changed:
- olive/telemetry/telemetry_extensions.py
- test/test_telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.

Comment thread olive/telemetry/recipe_telemetry.py Outdated
Use a stable <object> placeholder for unsupported config snapshot values so project-specific class names cannot enter recipe telemetry.

Files changed:
- olive/telemetry/recipe_telemetry.py
- test/workflows/test_workflow_run.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.

Comment thread olive/telemetry/deviceid/_store.py Outdated
Drop redundant wording above the explicit FileNotFoundError path.

Files changed:
- olive/telemetry/deviceid/_store.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.

Comment thread olive/telemetry/offline_store.py
Release the local SQLite connection when initialization fails before ownership transfers to the offline store, preventing leaked handles and locks.

Files changed:
- olive/telemetry/offline_store.py
- test/test_telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.

Comment thread olive/telemetry/telemetry.py
Clear the singleton initialization latch when store or setup initialization fails so transient errors can recover on a later construction attempt.

Files changed:
- olive/telemetry/telemetry.py
- test/test_telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated no new comments.

Refuse synchronous flush while the background thread is alive so it cannot release the process lock during an in-flight drain.

Files changed:
- olive/telemetry/uploader.py
- test/test_telemetry.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.

Comment thread olive/cli/launcher.py
Reset the initialization guard only after heartbeat, uploader, and store cleanup all complete so a later Telemetry() call can initialize a fresh session without racing live resources.

Files changed: olive/telemetry/telemetry.py; test/test_telemetry.py.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.

Comment thread olive/telemetry/telemetry.py
The stdlib SQLite migration removed the old logger service-name call, leaving APP_NAME unused. Remove the orphaned constant so the module reflects the active Common Schema path.

Files changed: olive/telemetry/telemetry.py.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9
Avoid waking every non-holder process for each local event. The designated lock holder still drains the shared SQLite queue immediately, while non-holders retain bounded takeover polling.

Files changed: olive/telemetry/uploader.py; test/test_telemetry.py.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: bccc32e8-3c9c-4fd6-a524-0dec207b03f9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants