Skip to content

Migrate CPU CI to GH#2587

Open
xiaoyu-work wants to merge 6 commits into
mainfrom
xiaoyu/github-actions-cpu-ci
Open

Migrate CPU CI to GH#2587
xiaoyu-work wants to merge 6 commits into
mainfrom
xiaoyu/github-actions-cpu-ci

Conversation

@xiaoyu-work

Copy link
Copy Markdown
Collaborator

Describe your changes

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

Copilot-Session: 95fa01d3-27be-4172-80da-0263c3eeb645
Copilot-Session: 95fa01d3-27be-4172-80da-0263c3eeb645
@xiaoyu-work xiaoyu-work changed the title Xiaoyu/GitHub actions cpu ci Migrate CPU CI to GH Jul 23, 2026
…ows CI failures

On Windows, HuggingFace loads .safetensors files using memory mapping,
which keeps file handles open. When tempfile.TemporaryDirectory exits
and tries to clean up, it fails with PermissionError [WinError 5].

Using ignore_cleanup_errors=True (Python 3.10+) prevents the cleanup
error from propagating and causing the test to fail.
Comment thread .github/workflows/cpu-ci.yml
@xiaoyu-work
xiaoyu-work marked this pull request as ready for review July 24, 2026 22:08
Copilot AI review requested due to automatic review settings July 24, 2026 22:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the CPU CI test execution from Azure Pipelines to GitHub Actions, and updates a few CLI smoke tests to be more tolerant of temporary-directory cleanup issues (common on Windows runners).

Changes:

  • Add a new GitHub Actions workflow to run CPU unit tests on Linux and Windows and upload JUnit + coverage artifacts.
  • Update CLI smoke tests to use TemporaryDirectory(ignore_cleanup_errors=True) to reduce teardown flakiness.
  • Comment out the Azure Pipelines CPU test jobs (effectively disabling them in the YAML).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
test/cli/test_cli_whisper_smoke.py Makes temp-dir cleanup more resilient during Whisper CLI smoke export test.
test/cli/test_cli_test_model_smoke.py Makes multiple smoke tests more resilient to temp-dir cleanup failures.
.github/workflows/cpu-ci.yml New GitHub Actions CPU CI workflow for Linux/Windows with artifacts.
.azure_pipelines/olive-ci.yaml Comments out Azure CPU CI jobs as part of moving CI to GitHub Actions.

Comment thread .azure_pipelines/olive-ci.yaml
Comment thread .github/workflows/cpu-ci.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants