Skip to content

Conversation

@jochenkirstaetter
Copy link
Contributor

Motivation and Context

I saw the initial PR to add Gemini Agent providers to the repository and tested it given the PR source code. However, the referenced Gemini model gemini-2.5-fast does not exist any more. I updated it to gemini-2.5-flash instead.

Description

Change the name of the Gemini model to an existing Flash 2.5 model. The previous reference to fast is not valid any more.

Contribution Checklist

  • [ X ] The code builds clean without any errors or warnings
  • [ X ] The PR follows the Contribution Guidelines
  • [ X ] All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot AI review requested due to automatic review settings December 8, 2025 11:58
@github-actions github-actions bot changed the title use proper Gemini model .NET: use proper Gemini model Dec 8, 2025
@jochenkirstaetter jochenkirstaetter changed the title .NET: use proper Gemini model .NET: use valid Gemini model Dec 8, 2025
@jochenkirstaetter
Copy link
Contributor Author

Note: I'm the maintainer of "a community driven Mscc.GenerativeAI.Microsoft package"

Cheers

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the default Google Gemini model name from the non-existent gemini-2.5-fast to the valid gemini-2.5-flash model in the sample code.

  • Updates the default model name to a valid Gemini 2.5 Flash model

@jochenkirstaetter
Copy link
Contributor Author

jochenkirstaetter commented Dec 8, 2025

Use named parameters explicitly to avoid ambiguous constructor methods because my package supports Google AI and Vertex AI interfaces. Also, ILogger interface is supported.

Cheers

@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Dec 10, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 10, 2025
* use proper Gemini model

* use named parameters

---------

Co-authored-by: Roger Barreto <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2025
@rogerbarreto rogerbarreto added this pull request to the merge queue Dec 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2025
@rogerbarreto rogerbarreto added this pull request to the merge queue Dec 10, 2025
Merged via the queue into microsoft:main with commit 0d9ae19 Dec 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants