Skip to content

feat(lock): Add lock file foundations#90

Merged
reubeno merged 4 commits intomicrosoft:mainfrom
dmcilvaney:damcilva/add_commit_lock_file_parts/1_lock_basics
Apr 10, 2026
Merged

feat(lock): Add lock file foundations#90
reubeno merged 4 commits intomicrosoft:mainfrom
dmcilvaney:damcilva/add_commit_lock_file_parts/1_lock_basics

Conversation

@dmcilvaney
Copy link
Copy Markdown
Contributor

Add the initial structure for saving and loading lock files. The lock files will track component identities and other metadata to help determine which components have changed, and to assist with generating changelogs and managing releases.

Add the initial structure for saving and loading lock files. The lock files will
track component identities and other metadata to help determine which components
have changed, and to assist with generating changelogs and managing releases.
Copilot AI review requested due to automatic review settings April 10, 2026 16:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a new internal lockfile package that provides the initial read/write foundations for an azldev.lock TOML lock file, intended to pin resolved component upstream commits for deterministic builds.

Changes:

  • Added LockFile / ComponentLock data model with helpers to set/get upstream commit locks.
  • Implemented TOML-based Load and Save for the lock file (with version gating).
  • Added unit tests covering round-trip behavior, sorting expectations, and common error cases.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
internal/lockfile/lockfile.go Adds lock file format/types and TOML load/save + helper methods.
internal/lockfile/lockfile_test.go Adds unit tests for lock file creation, persistence, ordering, and error handling.

Copilot AI review requested due to automatic review settings April 10, 2026 17:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

@reubeno reubeno merged commit 4c5e7d3 into microsoft:main Apr 10, 2026
15 checks passed
@dmcilvaney dmcilvaney deleted the damcilva/add_commit_lock_file_parts/1_lock_basics branch April 11, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants