fix: rust-nalgebra0.33: fix upstream-name to match component name#16487
Merged
christopherco merged 1 commit intotomls/base/mainfrom Apr 7, 2026
Merged
fix: rust-nalgebra0.33: fix upstream-name to match component name#16487christopherco merged 1 commit intotomls/base/mainfrom
christopherco merged 1 commit intotomls/base/mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Azure Linux component definition for rust-nalgebra0.33 to correct how the Fedora dist-git source is referenced for the pinned Fedora 43 snapshot.
Changes:
- Update
spec.upstream-nameforrust-nalgebra0.33torust-nalgebra0.33. - Update the pinned
spec.upstream-commitSHA for the Fedora 43 source.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -2,4 +2,4 @@ | |||
| # Pin to the f43 commit used to build the current Fedora 43 package. | |||
There was a problem hiding this comment.
The spec pin uses upstream-commit but the surrounding comment block doesn’t include a reference URL to the exact Fedora dist-git commit being pinned (and why), which makes it hard to audit/refresh later. Please add a full link (e.g., https://src.fedoraproject.org/rpms/rust-nalgebra0.33/c/<sha>) and keep the existing TODO/exit condition so it’s clear when this pin can be dropped.
Suggested change
| # Pin to the f43 commit used to build the current Fedora 43 package. | |
| # Pin to the Fedora 43 dist-git commit used to build the current Fedora 43 package: | |
| # https://src.fedoraproject.org/rpms/rust-nalgebra0.33/c/163057b9125cc59b4ce03b328ad6dc3be3d4b1a1 |
christopherco
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-nalgebra0.33: fix upstream-name to match component name
koji/taskinfo?taskID=1128253
closed buildSRPMFromSCM (/microsoft/azurelinux.git:35989ceaada603bdde40bb8c668863f7cceb76b3)
closed buildArch (rust-nalgebra0.33-0.33.2-1.azl4
bootstrap.20260405.src.rpm, x86_64)bootstrap.20260405.src.rpm, aarch64)closed buildArch (rust-nalgebra0.33-0.33.2-1.azl4
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology