Skip to content

fix(fuse3): pin to version 3.16.2 #16491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopherco merged 1 commit into from
Apr 7, 2026
+2 −1
Merged

fix(fuse3): pin to version 3.16.2 #16491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion base/comps/fuse3/fuse3.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# Pin to version 3.16.2. Version 3.17.x updates the soname and would break packages that depend on fuse3-libs
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream commit pin is missing a reference URL (e.g., the Fedora dist-git commit link) and an exit condition/TODO for when this pin can be removed. Adding those in the comment above the spec line makes it much easier to audit why we’re pinned and when we should re-align with the default Fedora 43 snapshot.

Suggested change
# Pin to version 3.16.2. Version 3.17.x updates the soname and would break packages that depend on fuse3-libs
# Pin to Fedora fuse3 3.16.2 because 3.17.x updates the soname and would break packages that depend on fuse3-libs.
# Fedora dist-git commit: https://src.fedoraproject.org/rpms/fuse3/c/f718bab813a887de21faa4a63ee1167c53348641
# TODO: Remove this pin and re-align with the default Fedora 43 snapshot once Azure Linux packages depending on fuse3-libs
# have been rebuilt or otherwise updated for the 3.17.x soname change.

Copilot uses AI. Check for mistakes.
[components.fuse3]
spec = { type = "upstream", upstream-name = "fuse3", upstream-distro = { name = "fedora", version = "42" } }
spec = { type = "upstream", upstream-commit = "f718bab813a887de21faa4a63ee1167c53348641" }
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes from an explicit Fedora 42 pin (upstream-distro = { name = "fedora", version = "42" }) to relying on defaults. Azure Linux’s default upstream distro is Fedora 43 (stage1/stage2), so if this commit is only reachable from the f42 dist-git history, azldev may fail to fetch/checkout it (or could re-align to Fedora 43 behavior unintentionally). Consider keeping upstream-distro = { name = "fedora", version = "42" } alongside upstream-commit to make the pin unambiguous and robust.

Suggested change
spec = { type = "upstream", upstream-commit = "f718bab813a887de21faa4a63ee1167c53348641" }
# Pin the upstream dist-git branch as well as the commit so azldev does not fall back to the
# Azure Linux default Fedora version and accidentally resolve against Fedora 43 behavior/history.
spec = { type = "upstream", upstream-distro = { name = "fedora", version = "42" }, upstream-commit = "f718bab813a887de21faa4a63ee1167c53348641" }

Copilot uses AI. Check for mistakes.
Loading