Skip to content

chore: hoist dependencies and solidify semver ranges #7231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
radium-v wants to merge 64 commits into
base: main
Choose a base branch
from
Open

chore: hoist dependencies and solidify semver ranges #7231

radium-v wants to merge 64 commits into from
+1,703 −1,460

Conversation

@radium-v
Copy link
Collaborator

@radium-v radium-v commented Dec 2, 2025

Pull Request

📖 Description

  • Hoist common dev dependencies (webpack, rollup, testing, type tooling, etc.) to the repo root and pin them to exact versions for deterministic installs.
  • Remove redundant package-level devDependencies, refresh TypeScript/tsconfig settings, and tighten import paths where hoisting required code updates.
  • Lock remaining workspace dependencies (express, tslib, website tooling, etc.) to explicit versions and drop unused packages to shrink install surface.

👩‍💻 Reviewer Notes

  • Verified TypeScript 5.3.3 at root doesn't cause type-checking conflicts in dependent packages. Some packages required updated tsconfig settings to align with root compiler options.
  • Verified package-level builds (fast-element, fast-router, fast-ssr, fast-html, and examples) still resolve hoisted devDependencies correctly.
  • Smoke tested the website/examples to ensure removing local assets or dependencies didn’t break their build steps.
  • Istanbul is replaced with NYC for code coverage as it has better monorepo support and fewer issues with hoisted dependencies. Since Karma is being phased out, this should have minimal impact.

📑 Test Plan

Installing, building, and testing should work as expected across the monorepo.

  • The test setup script in fast-element was modified to be pulled in directly by Karma/Webpack, since the module: ES2015 and moduleResolution: Node16 aren't valid together in TypeScript 5.3+. Since this module's job is already pulling in dist files, it's safe to just rewire it to run directly against those files.
  • Tests for fast-ssr were using external resources for some test images. Local assets already existed, so these tests were updated to use local images to improve reliability. (There was also a console log that was removed.)

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

  • Monitor CI for regressions caused by dependency hoisting.
  • Follow up with targeted documentation or scripts if additional packages need bespoke guidance after the cleanup.

marchbox
marchbox previously approved these changes Dec 2, 2025
View reviewed changes
@radium-v radium-v force-pushed the users/radium-v/semver-ranges branch 2 times, most recently from 7596895 to f227829 Compare December 3, 2025 18:39
@radium-v radium-v requested a review from marchbox December 3, 2025 18:56
marchbox
marchbox previously approved these changes Dec 3, 2025
View reviewed changes
@radium-v
chore: remove Babel dependencies from package.json and package-lock.json
922c6e6
@radium-v
fix: update @octokit/rest dependency version to exact match
3c27bfc
@radium-v
fix: update @playwright/test dependency version to exact match
104ef46
@radium-v
fix: remove unused @types/lodash-es dependency from package.json and …
1eb4ce0 
…package-lock.json
@radium-v
fix: update @typescript-eslint/eslint-plugin dependency version to ex…
6c86653 
…act match
@radium-v
fix: update @typescript-eslint/parser dependency version to exact match
6997281
@radium-v
fix: update beachball dependency version to exact match
4b80d6a
@radium-v
fix: remove chalk dependency from package.json and package-lock.json
8d85c38
@radium-v
fix: update concurrently dependency version to exact match
7062cec
@radium-v
fix: remove dotenv dependency from package.json and package-lock.json
095d3ba
@radium-v
fix: update eslint dependency version to exact match
304fa55
@radium-v
fix: update eslint-config-prettier dependency version to exact match
b1eed17
@radium-v
fix: update eslint-plugin-import dependency version to exact match
bc5ac45
@radium-v
fix: update glob dependency version to exact match
09ce12c
@radium-v
fix: update husky dependency version to exact match
10dd4ba
@radium-v
fix: update lint-staged dependency version to exact match
1517ef5
@radium-v
fix: update markdown-it dependency version to exact match
c9378ee
@radium-v
fix: update rimraf dependency version to exact match
f62d7d8
@radium-v
fix: remove ts-node dependency version
8e2a6b2
@radium-v
fix: update vite dependency version to exact match
386fbbd
@radium-v
remove prettier dev dependency from fast-element and fast-router
82fdc26
@radium-v
hoist typescript and lock to version 5.3.3
60f8a13
@radium-v
hoist rollup and lock to version 2.79.2
c7ebbbb
@radium-v
hoist rollup-plugin-filesize and lock to version 10.0.0
0b0a626
@radium-v
hoist source-map and lock to version 0.7.4
339d1aa
@radium-v
hoist source-map-loader and lock to version 5.0.0
1a79780
@radium-v
hoist ts-loader and lock to version 9.5.1
883996c
@radium-v
remove ts-node and tsconfig-paths from devDependencies in fast-elemen…
6cab610 
…t package.json
@radium-v
hoist webpack and lock to version 5.97.1
3a959d9
@radium-v
hoist webpack-cli and lock to version 5.1.4
8e7ce23
@radium-v
remove ts-node and tsconfig-paths from devDependencies in fast-router…
7e8e8ce 
… package.json
@radium-v
hoist fast-ssr dev dependencies and replace external test fixture assets
97d7c87
@radium-v
hoist @ast-grep/cli and lock to version 0.37.0
aa28c90
@radium-v
remove unnecessary devDependencies from fast-html package.json
0121e6a
@radium-v
remove concurrently dependency from website package.json
21a4d25
@radium-v
lock prism-react-renderer dependency to 2.3.1
da5251b
@radium-v
lock website dependencies
3430b70
@radium-v
update express dependency to version 4.22.1
0bc922e
@radium-v
fix: remove hoisted dev dependencies and fix import paths
bde2e94
@radium-v
remove unnecessary devDependencies from todo-app package.json and loc…
e275cb8 
…k dev dependency versions
@radium-v
fix: add missing types configuration in tsconfig.json
b8e8dc6
@radium-v
fix: move tslib to dependencies
817cf36
@radium-v
lock type package versions
60492ef
@radium-v
refactor: update testing configuration and dependencies
92c3a52 
- Removed deprecated `istanbul` and `karma-coverage-istanbul-reporter` packages.
- Added `nyc` for coverage reporting in Node.js tests.
- Updated Karma configuration to use `karma-coverage` instead of `karma-coverage-istanbul-reporter`.
- Adjusted coverage reporter settings to align with new package.
- Modified test scripts in `fast-element` and `fast-router` packages to utilize `nyc` for coverage reporting.
@radium-v
Change files
4efea69
@radium-v
update transitive dependencies
b6449aa
@radium-v radium-v force-pushed the users/radium-v/semver-ranges branch from f227829 to b6449aa Compare December 12, 2025 19:49
@radium-v radium-v requested a review from chrisdholt December 12, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

@marchbox marchbox marchbox left review comments

@janechu janechu Awaiting requested review from janechu janechu is a code owner

+1 more reviewer

@mohamedmansour mohamedmansour mohamedmansour approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@radium-v @mohamedmansour @marchbox @chrisdholt