This repository was archived by the owner on Oct 12, 2022. It is now read-only.
golang Dockerfile now using multistage build #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
@JoelPagliuca - as you might have already seen, the CircleCI build is failing because it is using NodeJS v4 - I'd pushed this commit as part of another PR that I opened a while ago. You might want to include (rebase/cherry-pick) that into this PR as well... :) |
Author
|
sure thing, haven't pulled cherry picked before, do you have a series of commands I can run to cherry-pick |
Contributor
|
These might help:
https://stackoverflow.com/questions/5120038/is-it-possible-to-cherry-pick-a-commit-from-another-git-repository/5120074#5120074
https://stackoverflow.com/questions/2474353/how-to-copy-commits-from-one-branch-to-another/2474430#2474430
…On Sat, Oct 6, 2018 at 3:51 AM Joel Pagliuca ***@***.***> wrote:
sure thing, haven't pulled cherry picked before, do you have a series of
commands I can run to cherry-pick 0c04637
into my multistage-golang branch?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#145 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKcQAHE3aesNTDvQWhuWdD5mh7mbnAdks5uiGEZgaJpZM4XKNEc>
.
|
Author
|
awesome, great finds, thanks for the help |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly changed the Dockerfile for GoLang projects to match the newer multistage build style