Python: Propagate MCP initialization failures#14095
Draft
lxingy3 wants to merge 1 commit into
Draft
Conversation
|
@lxingy3 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #13414.
When MCP streamable HTTP session initialization fails, for example after an authentication error from the server, the background connection task can raise before
ready_eventis set.connect()keeps waiting on that event, so the caller sees a hang instead of the initialization error.Description
This change makes the connection setup fail closed:
_inner_connect()setsready_eventbefore propagating any setup failure.connect()checks whether the background task already completed after the event is set, then awaits it so the originalKernelPluginInvalidConfigurationErrorreaches the caller.ClientSession.initialize()fails.Contribution Checklist
Validation:
python -m pytest python\tests\unit\connectors\mcp\test_mcp.py::test_streamable_http_initialization_failure_unblocks_connect -qpython -m pytest python\tests\unit\connectors\mcp\test_mcp.py -qpython -m ruff check python\semantic_kernel\connectors\mcp.py python\tests\unit\connectors\mcp\test_mcp.pygit diff --check