Clean up a bunch of unused localizations #19613
Conversation
DHowett
changed the title
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
Wow. It's cool to see all the changes we've made to Terminal over the years. Thanks for cleaning up the resources!
I really just have that one open question about the MinMaxCloseControl resources.
| <data name="WindowCloseButton.[using:Windows.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve"> | ||
| <value>Close</value> | ||
| </data> |
There was a problem hiding this comment.
It's weird that this one is removed, but the one underneath it is kept.
There was a problem hiding this comment.
Looking at MinMaxCloseControl.xaml, looks like we have CloseButton, MaximizeButton, and MinimizeButton. No WindowCloseButton etc (except there is WindowMinimizeButtonToolTip).
I think the right move here is to rename the resources so that they're attached to CloseButton etc. instead of WindowCloseButton etc.
There was a problem hiding this comment.
They're just not used, actually. Mike noted in #11680 that he had to manually create and display the tooltips.
The accessibility stuff has been unhooked since then too. In 2021.
| </data> | ||
| <data name="TerminalPage_PaneMovedAnnouncement_ExistingWindow" xml:space="preserve"> | ||
| <value>Active pane moved to "{0}" tab in "{1}" window</value> | ||
| <comment>{Locked="{0}"}{Locked="{1}"}This text is read out by screen readers upon a successful pane movement. {0} is the name of the tab the pane was moved to. {1} is the name of the window the pane was moved to. Replaced in 1.19 by TerminalPage_PaneMovedAnnouncement_ExistingWindow2</comment> | ||
| </data> | ||
| <data name="TerminalPage_PaneMovedAnnouncement_ExistingWindow2" xml:space="preserve"> | ||
| <value>Active pane moved to "{0}" window</value> | ||
| <comment>{Locked="{0}"}This text is read out by screen readers upon a successful pane movement. {0} is the name of the window the pane was moved to.</comment> |
There was a problem hiding this comment.
Can we keep TerminalPage_PaneMovedAnnouncement_ExistingWindow and update it with the correct value instead?
There was a problem hiding this comment.
Eh. It's not worth causing the loc to "churn" while everything rediscovers that the old key has the new value.
Well, they might be unused. A weird hacked-together PowerShell script I wrote told me.