Swapped naive dot product attention for flash attention#24
Open
usryokousha wants to merge 7 commits intomicrosoft:mainfrom
Open
Swapped naive dot product attention for flash attention#24usryokousha wants to merge 7 commits intomicrosoft:mainfrom
usryokousha wants to merge 7 commits intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
|
I ran into some issues using this branch as-is, and created a pull request for it here: usryokousha#1 Please review and pull in, if applicable. |
…ashAttention (e.g. no mask, fp/bf16)
Oh I must have overlooked that
Author
|
Please merge with master |
Author
|
Please merge with master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the Flash Attention mechanism to the MultiheadAttention module. Flash Attention is a recently proposed alternative to the conventional multi-head attention mechanism which reduces memory usage and improves training efficiency. The implementation in this pull request follows the paper "FlashAttention: Fast and Memory-Efficient Exact Attention with IO-Awareness" (https://arxiv.org/abs/2205.14135)
Changes Made:
Attention mechanism in the forward() method.
Replaced masked_fill with the additive mask to combine the attention mask and key padding mask.
Please review and merge.