Skip to content

Conversation

Copy link
Contributor

Copilot AI commented May 22, 2025

This PR adds an optional CI check that verifies changes to the TypeSpec repository are compatible with the Azure/typespec-azure repository.

What's been implemented

  • New GitHub workflow (typespec-azure-integration-check.yml) that:

    • Clones the Azure/typespec-azure repository
    • Automatically detects the "core" submodule in that repo
    • Updates the submodule to point to the current PR's commit
    • Runs build and tests to verify compatibility
    • Includes comprehensive logging and error handling
  • Added documentation in .github/workflows/README.md explaining how the workflow operates

Why this is useful

This check helps developers identify early if their changes to microsoft/typespec would break the Azure/typespec-azure repository, which depends on TypeSpec as a core dependency. It proactively prevents integration issues between the two repositories.

Technical details

  • Only runs on Linux with Node LTS as specified in requirements
  • Finds the TypeSpec submodule dynamically, handling different possible repository structures
  • Provides detailed logs with proper step grouping for easy debugging
  • Optional check that won't block PR merges

Fixes #5058.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cdn.fwupd.org
    • Triggering command: /usr/bin/fwupdmgr refresh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Add core submodule merge into Azure/typespec-azure as part of ci checks Add Azure/typespec-azure integration check to PR CI workflow May 22, 2025
Copilot AI requested a review from timotheeguerin May 22, 2025 17:54
Co-authored-by: timotheeguerin <[email protected]>
@github-actions
Copy link
Contributor

No changes needing a change description found.

Copy link
Member

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final results look great!

@chrisradek chrisradek enabled auto-merge May 23, 2025 17:26
auto-merge was automatically disabled May 23, 2025 17:29

Pull request was closed

@timotheeguerin timotheeguerin enabled auto-merge May 23, 2025 17:33
@timotheeguerin timotheeguerin added this pull request to the merge queue May 23, 2025
Merged via the queue into main with commit 057c883 May 23, 2025
25 of 28 checks passed
@timotheeguerin timotheeguerin deleted the copilot/fix-5058 branch May 23, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add core submodule merge into Azure/typespec-azure as part of ci checks

4 participants