-
Notifications
You must be signed in to change notification settings - Fork 322
Add Azure/typespec-azure integration check to PR CI workflow #7439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: timotheeguerin <[email protected]>
…d error handling Co-authored-by: timotheeguerin <[email protected]>
…heck Co-authored-by: timotheeguerin <[email protected]>
Co-authored-by: timotheeguerin <[email protected]>
Copilot
AI
changed the title
[WIP] Add core submodule merge into Azure/typespec-azure as part of ci checks
Add Azure/typespec-azure integration check to PR CI workflow
May 22, 2025
Co-authored-by: timotheeguerin <[email protected]>
Co-authored-by: timotheeguerin <[email protected]>
Co-authored-by: timotheeguerin <[email protected]>
Contributor
|
No changes needing a change description found. |
Co-authored-by: timotheeguerin <[email protected]>
chrisradek
approved these changes
May 23, 2025
Member
chrisradek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final results look great!
chrisradek
approved these changes
May 23, 2025
chrisradek
approved these changes
May 23, 2025
chrisradek
approved these changes
May 23, 2025
chrisradek
approved these changes
May 23, 2025
chrisradek
approved these changes
May 23, 2025
lmazuel
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional CI check that verifies changes to the TypeSpec repository are compatible with the Azure/typespec-azure repository.
What's been implemented
New GitHub workflow (
typespec-azure-integration-check.yml) that:Added documentation in
.github/workflows/README.mdexplaining how the workflow operatesWhy this is useful
This check helps developers identify early if their changes to microsoft/typespec would break the Azure/typespec-azure repository, which depends on TypeSpec as a core dependency. It proactively prevents integration issues between the two repositories.
Technical details
Fixes #5058.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.fwupd.org/usr/bin/fwupdmgr refresh(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.