[physx] Add patch for NVIDIAGameWorks/PhysX#322.#12413
Merged
strega-nil merged 4 commits intomicrosoft:masterfrom Jul 31, 2020
Merged
[physx] Add patch for NVIDIAGameWorks/PhysX#322.#12413strega-nil merged 4 commits intomicrosoft:masterfrom
strega-nil merged 4 commits intomicrosoft:masterfrom
Conversation
NancyLi1013
added
the
category:port-feature
NancyLi1013
reviewed
Jul 14, 2020
Contributor
NancyLi1013
left a comment
NancyLi1013
left a comment
There was a problem hiding this comment.
Could you please remove include(vcpkg_common_functions)? Since it is not needed here.
Also please use VCPKG_TARGET_IS_WINDOW, VCPKG_TARGET_IS_UWP to judge the platforms instead of using VCPKG_CMAKE_SYSTEM_NAME.
Contributor
Author
|
I have fixed the platform logic to no longer check |
NancyLi1013
suggested changes
Jul 15, 2020
Contributor
Author
|
Updated to convert all space-based indentation to tabs. |
NancyLi1013
reviewed
Jul 15, 2020
Contributor
Author
|
More indentation adjustments have been pushed. |
NancyLi1013
approved these changes
Jul 16, 2020
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
added
the
info:needs-maintainer-attention
Merged
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hellozee
pushed a commit
to hellozee/vcpkg
that referenced
this pull request
Sep 11, 2020
* [physx] Add patch for NVIDIAGameWorks/PhysX#322. * [physx] Cleanup usage of `VCPKG_CMAKE_SYSTEM_NAME`. * [physx] Convert portfile space indentation to tabs. * Update portfile.cmake Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request allows applications to link with a statically built PhysX SDK and the Autodesk 3ds Max SDK by hiding certain internal PhysX symbols in an internal namespace (the specific conflicting symbol in this case is the class
BitArray). This patch was submitted to NVIDIA, however, the PhysX repository is not actively matained. Even accepted pull requests are not actually merged and are instead included as patches in vcpkg.