[vsgxchange] Update to 1.1.13#51691
Conversation
|
Depends on #51690 |
0923a93 to
32775ee
Compare
|
I tried patch |
|
Thanks for bringing this to my attention. I am out of the office today but
on my return will investigate and figure out a fix.
…On Wed, 13 May 2026, 07:46 Weihang Ding, ***@***.***> wrote:
*xiaozhuai* left a comment (microsoft/vcpkg#51691)
<#51691 (comment)>
vsgxchange 1.1.12 fails when the assimp feature is disabled.
This is an upstream issue.
I've tried patch src/assimp/assimp_fallback.cpp to include #include
<vsgXchange/assimp.h>, but it didn't work.
src/assimp/assimp_fallback.cpp:21:7: error: use of undeclared identifier 'assimp'
src/assimp/assimp_fallback.cpp:43:26: error: unknown type name 'Features'
CC @robertosfield <https://github.com/robertosfield>
—
Reply to this email directly, view it on GitHub
<#51691 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKEGUELDIVBBZ2GPDDDFD342QK6BAVCNFSM6AAAAACY2KLLQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DIMZYGEZDKNJQGA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I have checked in a build fix to vsgXchange master: |
|
I have also updated vsgExamples to handling optional parts of vsgXchange: I have also tagged a vsgXchange-1.1.13 and vsgExamples-1.1.14 dev releases to wrap up these fixes: https://github.com/vsg-dev/vsgXchange/releases/tag/v1.1.13 |
|
@robertosfield Thanks for the quick fix! |
|
@robertosfield New linking issue with |
|
I have added #ifdef's around the vsgXchange::assimp::Builder class and related declarations: I am currently working on Kubuntu so will boot up my Windows 11 system and try disabling the assimp in vsgXchange to make sure this commit resolves the issue. @xiaozhuai if you could test this commit out as well, if this testing works then I'll tag another dev release. |
|
I have done a Windows 11 build of vsgXchange with assimp disabled and found another build error which I resolved with this commit: |
|
My local build of vsgXchange with assimp disabled is now compiling cleanly so I've assumed it'll also work for you and gone ahead a redone the vsgXchange-v1.1.13 so it now includes all the associated fixes. Fingers crossed v1.1.13 will now work for you. |
|
Changes I've made since vsgXchange-v.1.1.12: vsg-dev/vsgXchange@v1.1.12...v1.1.13 |
|
@robertosfield The new |
./vcpkg x-add-version --alland committing the result.