New port libspatialaudio#51701
Draft
jlskuz wants to merge 2 commits into
Draft
Conversation
vicroms
requested changes
May 12, 2026
Member
vicroms
left a comment
There was a problem hiding this comment.
Some Copilot findings:
Upstream bundles third-party code, source/kiss_fft and source/mit_hrtf. The bundled sources should be removed before building and the meson.build script modified to accept vcpkg dependencies instead.
Optional, remove the tests from the build. Meson unconditionally adds tests and the build compiled/linked all four test executables. They are not installed, so this is not a packaging leak, but it is avoidable build work if upstream can be patched to add a test toggle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner-Projectform.vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGEvcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.