Skip to content

New port libspatialaudio#51701

Draft
jlskuz wants to merge 2 commits into
microsoft:masterfrom
jlskuz:new_port/libspatialaudio
Draft

New port libspatialaudio#51701
jlskuz wants to merge 2 commits into
microsoft:masterfrom
jlskuz:new_port/libspatialaudio

Conversation

@jlskuz
Copy link
Copy Markdown
Contributor

@jlskuz jlskuz commented May 12, 2026

  • Changes comply with the maintainer guide.
  • The packaged project shows strong association with the chosen port name. Check this box if at least one of the following criteria is met:
    • The project is in Repology: https://repology.org/project/libspatialaudio/versions
    • The project is amongst the first web search results for "" or " C++". Include a screenshot of the search engine results in the PR. image
    • The port name follows the 'GitHubOrg-GitHubRepo' form or equivalent Owner-Project form.
  • Optional dependencies of the build are all controlled by the port. A dependency is controlled if it is declared an unconditional dependency in vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGE
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is brief and accurate. See adding-usage for context. Don't add a usage file if the automatically generated usage is correct.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

@jlskuz jlskuz changed the title New port/libspatialaudio New port libspatialaudio May 12, 2026
Copy link
Copy Markdown
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Copilot findings:

Upstream bundles third-party code, source/kiss_fft and source/mit_hrtf. The bundled sources should be removed before building and the meson.build script modified to accept vcpkg dependencies instead.

Optional, remove the tests from the build. Meson unconditionally adds tests and the build compiled/linked all four test executables. They are not installed, so this is not a packaging leak, but it is avoidable build work if upstream can be patched to add a test toggle.

@vicroms vicroms marked this pull request as draft May 12, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants