Skip to content

Move git spec out of upstream, and fix issues around fetching many git commits - #260749

Merged
Daniel Imms (Tyriar) merged 5 commits into
mainfrom
tyriar/260748
Aug 9, 2025
Merged

Move git spec out of upstream, and fix issues around fetching many git commits#260749
Daniel Imms (Tyriar) merged 5 commits into
mainfrom
tyriar/260748

Conversation

@Tyriar

@Tyriar Daniel Imms (Tyriar) commented Aug 9, 2025

Copy link
Copy Markdown
Contributor

Fixes #260748
Fixes #260160

  • Move git spec out of upstream, fix lint issues
  • Fix commit generator hash length
  • Restrict git commit history fetching to 1000 latest (>1s to < 100ms)
  • Prevent call stack limit issues due to spread operator vs .concat

@Tyriar Daniel Imms (Tyriar) added this to the August 2025 milestone Aug 9, 2025
@Tyriar Daniel Imms (Tyriar) self-assigned this Aug 9, 2025
@Tyriar
Daniel Imms (Tyriar) marked this pull request as draft August 9, 2025 11:47
@Tyriar Daniel Imms (Tyriar) changed the title Fix commit generator hash length Move git spec out of upstream, and fix issues around fetching many git commits Aug 9, 2025
@Tyriar
Daniel Imms (Tyriar) marked this pull request as ready for review August 9, 2025 12:54
@Tyriar
Daniel Imms (Tyriar) merged commit dafc6c5 into main Aug 9, 2025
18 checks passed
@Tyriar
Daniel Imms (Tyriar) deleted the tyriar/260748 branch August 9, 2025 15:33
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Sep 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal suggest git commit generator doesn't handle hash length right Terminal suggest: git cherry-pick flags aren't supported

2 participants