Always report when gpu acceleration is enabled #281992
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies the input latency telemetry collection logic to always report telemetry data when GPU acceleration is enabled, in addition to the existing random 1% sampling. The change treats GPU acceleration as an opt-in experimental feature that warrants additional monitoring.
Key changes:
- Added a condition to enable telemetry reporting when
editor.experimentalGpuAccelerationis set to 'on' - Updated the comment to explain this behavior
| if (Math.random() <= 0.01) { | ||
| // Only log 1% of users selected randomly to reduce the volume of data, always report if GPU | ||
| // acceleration is enabled as it's opt-in | ||
| if (Math.random() <= 0.01 || this._configurationService.getValue('editor.experimentalGpuAcceleration') === 'on') { |
There was a problem hiding this comment.
The GPU acceleration check happens once during construction. If a user enables or disables GPU acceleration after the component is initialized, the telemetry reporting behavior won't update accordingly. Consider either:
- Adding a listener for configuration changes to update the behavior dynamically, or
- Checking the configuration value in the
_logSamples()method each time telemetry is sent (line 83 already reads the current value)
This would ensure that telemetry accurately reflects the current GPU acceleration state rather than the state at initialization.
There was a problem hiding this comment.
Wanted to avoid adding more code, it's fine that this only applies to those that have it on startup only. It'll eventually get removed as more users go on it.
No description provided.