Align Custom OAI tool_search availability#315480
Open
PenguinDOOM wants to merge 5 commits into
Open
Conversation
- pin gpt-5.4 and gpt-5.5 capability expectations - add failing availability handoff regression - preserve request-builder control coverage
- admit gpt-5.4 and gpt-5.5 in tool_search allowlist - keep supportsToolSearch runtime gating unchanged - extend intent-layer include and exclusion coverage
- keep responsesApi.ts unchanged after request proof - pin prompt deferred-tool guidance to supportsToolSearch - verify supported Custom OAI Responses request path stays green
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns tool_search availability for Custom OAI Responses with the existing gpt-5.4 / gpt-5.5 capability gating, and adds focused tests to validate the end-to-end behavior across capability checks, tool enablement, request construction, and prompt guidance.
Changes:
- Added
gpt-5.4andgpt-5.5to the model allowlist for thetool_searchtool definition. - Expanded unit/integration coverage for capability gating, agent tool enablement, and Responses API request body tool injection behavior.
- Added prompt-level tests ensuring deferred-tool guidance and tool-search sections are gated by
endpoint.supportsToolSearch.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/platform/endpoint/test/node/chatModelCapabilities.spec.ts | Refines/extends tests for modelSupportsToolSearch including explicit gpt-5.4/5.5 flag-enabled/disabled cases. |
| extensions/copilot/src/platform/endpoint/node/test/responsesApiToolSearch.spec.ts | Adds coverage for client tool_search injection behavior for CustomOAI Responses on gpt-5.4/5.5 and omission when upstream tools exclude it. |
| extensions/copilot/src/extension/tools/node/toolSearchTool.ts | Allows tool_search to apply to exact gpt-5.4 and gpt-5.5 model IDs. |
| extensions/copilot/src/extension/tools/node/test/testToolsService.ts | Updates test tools service to surface applicable model-specific tool definitions during tool enablement. |
| extensions/copilot/src/extension/prompts/node/agent/test/agentPrompt.spec.tsx | Adds tests to ensure tool-search guidance/list sections are gated by endpoint.supportsToolSearch for gpt-5.4/5.5. |
| extensions/copilot/src/extension/intents/node/test/backgroundTodoEnablement.spec.ts | Adds tests validating tool_search presence/absence in agent tools for CustomOAI gpt-5.4/5.5 based on endpoint capability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns tool_search static applicability with the existing gpt-5.4 and gpt-5.5 capability gate for Custom OAI Responses.
What changed:
How this differs from #313803:
Validation: