[cherry-pick] Cache terminal risk assessment by command only#315685
Merged
Conversation
chrmarti
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#315616
Cherry-pick of #315663 from
main.Summary
Fixes the terminal confirmation badge showing
Assessing risk…with a spinner every time, instead of using the cached assessment, when re-running the same command outside the sandbox.The risk assessment cache key was
tool.id + stableStringify(parameters). Forrun_in_terminalthe parameter set includes model-generatedexplanation,goal, andrequestUnsandboxedExecutionReasonfields, which differ on every invocation even when the underlying command is identical — so the cache never hit on the second run.This narrows the cache key for
run_in_terminalto just `{ command }`. Other tools are unaffected and still key on their full parameter set.Repro
Session Context
Key decisions from the development session: