Skip to content

Add option for full-spoke radial trajectory#116

Open
fyrdahl wants to merge 1 commit into
mikgroup:mainfrom
fyrdahl:radial_traj
Open

Add option for full-spoke radial trajectory#116
fyrdahl wants to merge 1 commit into
mikgroup:mainfrom
fyrdahl:radial_traj

Conversation

@fyrdahl

@fyrdahl fyrdahl commented Aug 15, 2022

Copy link
Copy Markdown

I noticed that the radial trajectory code defaulted to half-spoke (center-out) with no option to use full spokes, so I added that option. The default behavior doesn't change, but the new option is a closer match to what is described in the referenced papers.
The change to beta in the full-spoke 3D-radial case is not strictly necessary, but the change reflects how it's described in the original paper.

I also changed the deprecated np.float to np.float32, as I understand you prefer explicit size instead of the built-in types.

@curtcorum

Copy link
Copy Markdown

Any ideas why the checks failed? Not much info available from travis ci without a login?

@fyrdahl

fyrdahl commented Jan 11, 2023

Copy link
Copy Markdown
Author

It's a bunch of failed flake8 tests, most of which seem unrelated to this PR. The failed test which I believe is related is an E501 line too long.

./sigpy/mri/samp.py:90:80: E501 line too long (83 > 79 characters)

Since most errors are unrelated to this PR, fixing the PR itself probably won't solve the failed checks. I think PEP8 should be abided by when possible but breaking up the argument list into multiple lines is a departure from the coding style in the rest of the code base. This will probably become a bigger problem when someone gets around to fixing the deprecated datatypes, which will add 2-3 chars to every line that specifies a dtype.

@sidward

sidward commented May 27, 2023

Copy link
Copy Markdown
Collaborator

Hi, sorry -- I updated the tooling. Can you please run bash run_tests.sh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants