Skip to content

Refactor oxlint child env handling#901

Draft
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/codebase-architecture-elegance-afc0
Draft

Refactor oxlint child env handling#901
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/codebase-architecture-elegance-afc0

Conversation

@cursor

@cursor cursor Bot commented Jun 19, 2026

Copy link
Copy Markdown

Summary

  • build the oxlint child env at spawn time instead of import time
  • make compile-cache opt-out authoritative and treat empty cache paths as unset
  • simplify byte accounting/settlement in spawnOxlint and tighten tests/prose

Verification

  • pnpm --filter @react-doctor/core exec vp test run tests/build-oxlint-child-env.test.ts tests/spawn-oxlint-compile-cache.test.ts
  • pnpm --filter @react-doctor/core typecheck
  • pnpm exec vp fmt --check .changeset/propagate-compile-cache-oxlint-children.md packages/core/src/constants.ts packages/core/src/runners/oxlint/spawn-oxlint.ts packages/core/src/utils/build-oxlint-child-env.ts packages/core/tests/build-oxlint-child-env.test.ts packages/core/tests/spawn-oxlint-compile-cache.test.ts
  • pnpm --filter @react-doctor/core exec vp test run
  • pnpm lint
  • pnpm typecheck
  • pnpm format:check
  • pnpm build
  • pnpm smoke:json-report
  • pnpm test
Open in Web View Automation 

cursoragent and others added 2 commits June 19, 2026 16:15
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rde parity

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

@pkg-pr-new

pkg-pr-new Bot commented Jun 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@901
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@901
npm i https://pkg.pr.new/react-doctor@901

commit: f01e944

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup complete for the scoped compile-cache change.

What changed:

  • spawnOxlint now builds the child env at spawn time instead of freezing process.env at module load.
  • buildOxlintChildEnv now skips undefined env values, treats empty NODE_COMPILE_CACHE as unset, and makes NODE_DISABLE_COMPILE_CACHE authoritative.
  • Simplified output byte accounting and single-settlement handling in spawnOxlint.
  • Trimmed over-specific comments/changeset prose and made the compile-cache spawn test deterministic.

Verification:

  • Full local: pnpm build, pnpm smoke:json-report, pnpm test
  • Root checks: pnpm lint, pnpm typecheck, pnpm format:check
  • Core focused/full: touched tests, core typecheck, full @react-doctor/core test suite
  • PR checks observed green, including CI matrix, Code Quality, CodeQL, React Doctor, and Publish Any Commit.

Skipped recommendations:

  • Broader deslop findings outside this diff, such as unrelated unused exported types and fixture simplifications.
  • Wider child-env unification with dead-code workers, because that changes a separate runner contract.
  • truffler could not run in this image because it requires bun; I used repo search fallback for the post-change duplicate sweep.

I posted /rde parity as requested via the available PR review channel and watched the PR afterward. No Bugbot comments or RDE parity response appeared during the wait.

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant