Refactor oxlint child env handling#901
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
commit: |
Author
There was a problem hiding this comment.
Cleanup complete for the scoped compile-cache change.
What changed:
spawnOxlintnow builds the child env at spawn time instead of freezingprocess.envat module load.buildOxlintChildEnvnow skips undefined env values, treats emptyNODE_COMPILE_CACHEas unset, and makesNODE_DISABLE_COMPILE_CACHEauthoritative.- Simplified output byte accounting and single-settlement handling in
spawnOxlint. - Trimmed over-specific comments/changeset prose and made the compile-cache spawn test deterministic.
Verification:
- Full local:
pnpm build,pnpm smoke:json-report,pnpm test - Root checks:
pnpm lint,pnpm typecheck,pnpm format:check - Core focused/full: touched tests, core typecheck, full
@react-doctor/coretest suite - PR checks observed green, including CI matrix, Code Quality, CodeQL, React Doctor, and Publish Any Commit.
Skipped recommendations:
- Broader deslop findings outside this diff, such as unrelated unused exported types and fixture simplifications.
- Wider child-env unification with dead-code workers, because that changes a separate runner contract.
trufflercould not run in this image because it requiresbun; I used repo search fallback for the post-change duplicate sweep.
I posted /rde parity as requested via the available PR review channel and watched the PR afterward. No Bugbot comments or RDE parity response appeared during the wait.
Sent by Cursor Automation: React Doctor Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
spawnOxlintand tighten tests/proseVerification
pnpm --filter @react-doctor/core exec vp test run tests/build-oxlint-child-env.test.ts tests/spawn-oxlint-compile-cache.test.tspnpm --filter @react-doctor/core typecheckpnpm exec vp fmt --check .changeset/propagate-compile-cache-oxlint-children.md packages/core/src/constants.ts packages/core/src/runners/oxlint/spawn-oxlint.ts packages/core/src/utils/build-oxlint-child-env.ts packages/core/tests/build-oxlint-child-env.test.ts packages/core/tests/spawn-oxlint-compile-cache.test.tspnpm --filter @react-doctor/core exec vp test runpnpm lintpnpm typecheckpnpm format:checkpnpm buildpnpm smoke:json-reportpnpm test