Refactor license warning detection#948
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
commit: |
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Author
There was a problem hiding this comment.
Implemented the cleanup pass.
Summary:
- Centralized AI/ML license detection + warn-once behavior in core and reused it from CLI/API.
- Narrowed detection to higher-confidence pipeline/session markers and added focused detector + CLI warning tests.
- Fixed API
diagnose()layer gating forlint: false/deadCode: falseand reused pre-resolved config. - Aligned license docs/changeset text and added missing package-local
LICENSEfiles. - Fixed the macOS LSP integration timeout that failed on the first PR run.
Verification:
- Local focused tests,
typecheck,lint,build,smoke:json-report, and fullpnpm testpassed. - PR checks are green after the second push, including macOS and Windows.
Notes:
- Posted
/rde parityas requested; no RDE response or Bugbot comments were visible when checked. trufflercould not run because its installed CLI requiresbun, which is not present, so I used targetedrgsearches for the post-change dedupe pass.
Sent by Cursor Automation: React Doctor Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
lint/deadCodeand reuse pre-resolved configVerification
NODE_OPTIONS=--experimental-strip-types pnpm exec vp test run tests/detect-ai-training-environment.test.tsinpackages/coreNODE_OPTIONS=--experimental-strip-types pnpm exec vp test run tests/warn-ai-training-environment.test.tsinpackages/react-doctorNODE_OPTIONS=--experimental-strip-types pnpm exec vp test run tests/diagnose.test.tsinpackages/apiNODE_OPTIONS=--experimental-strip-types pnpm typecheckNODE_OPTIONS=--experimental-strip-types pnpm lintNODE_OPTIONS=--experimental-strip-types pnpm buildNODE_OPTIONS=--experimental-strip-types pnpm smoke:json-reportNODE_OPTIONS=--experimental-strip-types pnpm test