Skip to content

Refactor license warning detection#948

Draft
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/codebase-architecture-elegance-e8f7
Draft

Refactor license warning detection#948
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/codebase-architecture-elegance-e8f7

Conversation

@cursor

@cursor cursor Bot commented Jun 23, 2026

Copy link
Copy Markdown

Summary

  • centralize AI/ML license notice detection and warn-once behavior in core
  • narrow detection to higher-confidence pipeline/session markers and add tests
  • align API layer gating for lint/deadCode and reuse pre-resolved config
  • update README/license metadata consistency and add missing package-local LICENSE files

Verification

  • NODE_OPTIONS=--experimental-strip-types pnpm exec vp test run tests/detect-ai-training-environment.test.ts in packages/core
  • NODE_OPTIONS=--experimental-strip-types pnpm exec vp test run tests/warn-ai-training-environment.test.ts in packages/react-doctor
  • NODE_OPTIONS=--experimental-strip-types pnpm exec vp test run tests/diagnose.test.ts in packages/api
  • NODE_OPTIONS=--experimental-strip-types pnpm typecheck
  • NODE_OPTIONS=--experimental-strip-types pnpm lint
  • NODE_OPTIONS=--experimental-strip-types pnpm build
  • NODE_OPTIONS=--experimental-strip-types pnpm smoke:json-report
  • NODE_OPTIONS=--experimental-strip-types pnpm test
Open in Web View Automation 

Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rde parity

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

@pkg-pr-new

pkg-pr-new Bot commented Jun 23, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@948
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@948
npm i https://pkg.pr.new/react-doctor@948

commit: 8c2f791

Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented the cleanup pass.

Summary:

  • Centralized AI/ML license detection + warn-once behavior in core and reused it from CLI/API.
  • Narrowed detection to higher-confidence pipeline/session markers and added focused detector + CLI warning tests.
  • Fixed API diagnose() layer gating for lint: false / deadCode: false and reused pre-resolved config.
  • Aligned license docs/changeset text and added missing package-local LICENSE files.
  • Fixed the macOS LSP integration timeout that failed on the first PR run.

Verification:

  • Local focused tests, typecheck, lint, build, smoke:json-report, and full pnpm test passed.
  • PR checks are green after the second push, including macOS and Windows.

Notes:

  • Posted /rde parity as requested; no RDE response or Bugbot comments were visible when checked.
  • truffler could not run because its installed CLI requires bun, which is not present, so I used targeted rg searches for the post-change dedupe pass.

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant