fix: disable react-hooks-js/incompatible-library rule#951
Draft
skoshx wants to merge 2 commits into
Draft
Conversation
The react-hooks-js/incompatible-library rule from React Compiler is overly aggressive and flags well-designed, battle-tested libraries like @tanstack/react-virtual, @tanstack/react-table, and similar TanStack libraries. These libraries are specifically designed to work with React and don't present the compatibility issues the rule is trying to catch. The current remediation guidance can push users away from mature virtualization/data libraries toward fragile, handwritten implementations. This change removes react-hooks-js/incompatible-library from EXTERNAL_RULES, preventing it from being enabled in the oxlint config. Closes #950 Co-authored-by: Skosh <skoshx@users.noreply.github.com>
Co-authored-by: Skosh <skoshx@users.noreply.github.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
The
react-hooks-js/incompatible-libraryrule from React Compiler is overly aggressive and flags well-designed, battle-tested libraries like@tanstack/react-virtual,@tanstack/react-table, and similar TanStack libraries.These libraries are specifically designed to work with React and don't present the compatibility issues the rule is trying to catch. The current remediation guidance can push users away from mature virtualization/data libraries toward fragile, handwritten implementations.
Changes
react-hooks-js/incompatible-libraryfromEXTERNAL_RULESinpackages/oxlint-plugin-react-doctor/src/rules.tspackages/react-doctor/tests/regressions/scan-resilience.test.tsto ensure the rule stays disabledScope Decision
This change completely disables the
react-hooks-js/incompatible-libraryrule rather than allowlisting specific libraries because:Testing
Expected Parity Results
Since this change only removes a rule (doesn't modify detection logic), the parity diff should show:
react-hooks-js/incompatible-librarydiagnostics that previously fired across the corpusThis is the intended behavior - we're silencing an overly aggressive rule that was generating false positives on well-designed React libraries.
Closes #950