Skip to content

Fix diagnose lint toggle and tighten audit cleanup#953

Draft
cursor[bot] wants to merge 4 commits into
mainfrom
cursor/codebase-architecture-elegance-b833
Draft

Fix diagnose lint toggle and tighten audit cleanup#953
cursor[bot] wants to merge 4 commits into
mainfrom
cursor/codebase-architecture-elegance-b833

Conversation

@cursor

@cursor cursor Bot commented Jun 24, 2026

Copy link
Copy Markdown

Summary

  • Honor diagnose(..., { lint: false }) by skipping the oxlint layer in the programmatic API
  • Dispatch :exit visitors in the oxlint rule test runner so rule tests match runtime traversal
  • Strengthen run-oxlint fixture assertions to verify diagnostics come from the intended fixture
  • Remove a dead deslop script-entry glob path and update the GitHub Action contract test for scope

Verification

  • pnpm --filter @react-doctor/api test
  • pnpm --filter oxlint-plugin-react-doctor test
  • pnpm --filter react-doctor test
  • pnpm test:deslop
  • pnpm typecheck
  • pnpm smoke:json-report

pnpm lint and pnpm format:check are blocked in this environment because the config loader rejects the machine Node version (v22.14.0) for TypeScript config loading.

Open in Web View Automation 

cursoragent and others added 2 commits June 24, 2026 16:12
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rde parity

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

@pkg-pr-new

pkg-pr-new Bot commented Jun 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@953
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@953
npm i https://pkg.pr.new/react-doctor@953

commit: f90f779

cursoragent and others added 2 commits June 24, 2026 16:27
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Audit cleanup completed.

Fixed:

  • diagnose(..., { lint: false }) now skips the oxlint layer instead of silently linting anyway.
  • The oxlint rule test runner now dispatches node.type:exit visitors, matching runtime traversal more closely.
  • describeRules now asserts the rule fired in the intended fixture file.
  • Removed a dead deslop SCRIPT_ENTRY_PATTERNS path that always globbed an empty list.
  • Added the missing scope input to the GitHub Action contract test.

Verified locally:

  • pnpm --filter @react-doctor/api test
  • pnpm --filter oxlint-plugin-react-doctor test
  • pnpm --filter react-doctor test
  • pnpm test:deslop
  • pnpm typecheck
  • npx -y -p node@22.18.0 -c 'pnpm format:check'
  • pnpm smoke:json-report

PR checks are green on the latest commit. I posted /rde parity earlier; no Bugbot/RDE follow-up comments appeared during polling.

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant