Fix diagnose lint toggle and tighten audit cleanup#953
Draft
cursor[bot] wants to merge 4 commits into
Draft
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
commit: |
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Author
There was a problem hiding this comment.
Audit cleanup completed.
Fixed:
diagnose(..., { lint: false })now skips the oxlint layer instead of silently linting anyway.- The oxlint rule test runner now dispatches
node.type:exitvisitors, matching runtime traversal more closely. describeRulesnow asserts the rule fired in the intended fixture file.- Removed a dead deslop
SCRIPT_ENTRY_PATTERNSpath that always globbed an empty list. - Added the missing
scopeinput to the GitHub Action contract test.
Verified locally:
pnpm --filter @react-doctor/api testpnpm --filter oxlint-plugin-react-doctor testpnpm --filter react-doctor testpnpm test:desloppnpm typechecknpx -y -p node@22.18.0 -c 'pnpm format:check'pnpm smoke:json-report
PR checks are green on the latest commit. I posted /rde parity earlier; no Bugbot/RDE follow-up comments appeared during polling.
Sent by Cursor Automation: React Doctor Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
diagnose(..., { lint: false })by skipping the oxlint layer in the programmatic API:exitvisitors in the oxlint rule test runner so rule tests match runtime traversalscopeVerification
pnpm --filter @react-doctor/api testpnpm --filter oxlint-plugin-react-doctor testpnpm --filter react-doctor testpnpm test:desloppnpm typecheckpnpm smoke:json-reportpnpm lintandpnpm format:checkare blocked in this environment because the config loader rejects the machine Node version (v22.14.0) for TypeScript config loading.