CLI : added unit test files for project and project role by DharunMR · Pull Request #6418 · mindersec/minder

DharunMR · 2026-04-25T03:09:32Z

Description

Continuing the pattern in #6386:

This PR introduces a comprehensive refactor of the cmd/cli/app/project and cmd/cli/app/project/role package to modernize its testing architecture, improve separation of concerns. Stripped out manual ctx and grpc.ClientConn arguments from command execution functions to align with standard Cobra RunE signatures. Implemented the "backpack" pattern using cmd.SetContext(ctx) and cli.WithRPCClient to inject mock clients cleanly during testing.

🧪 How to Test

Run standard tests: go test ./... (Should PASS)
Run test if any changes made in cmd code then add -update flag: go test ./cmd/cli/app/project/ -update and go test ./cmd/cli/app/project/role -update

Signed-off-by: DharunMR <maddharun56@gmail.com>

coveralls · 2026-04-25T03:21:11Z

Coverage is 60.387% — DharunMR:test-project-cmd into mindersec:main. No base build found for mindersec:main.

evankanderson

See also my comment on #6420 about having a generic cmd -> grpc client function.

DharunMR · 2026-04-28T06:32:06Z

See also my comment on #6420 about having a generic cmd -> grpc client function.

i think this pr needs to wait until #6420 got merged, so that i dont double do code changes and simply rebase

evankanderson · 2026-04-30T20:54:42Z

#6420 got merged, but we probably need to address #6417 (comment) -- coordinate with @sachin9058 on who's going to fix it. (TL;DR - Google deliberately makes protojson marshalling non-stable by inserting semantically meaningless spaces based on the build info.)

sachin9058 · 2026-04-30T21:14:03Z

Thanks for the heads up!

I’ve been working on this in #6417 the issue comes from protojson output not being stable across environments, which causes flaky golden tests due to spacing differences.

In my PR, I removed JSON golden tests and kept table/yaml outputs to avoid this instability.

Happy to coordinate here we can either follow the same approach (skip JSON golden tests) or decide on a shared normalization strategy if we want to keep them.

evankanderson · 2026-04-30T23:19:20Z

@sachin9058 filed #6430 to track the JSON golden test problem.

evankanderson

Sorry for missing the comments on this earlier in the protojson-is-nondeterministic excitement.

evankanderson · 2026-05-05T21:47:38Z

+    {
+      "displayName": "Mock Admin",
+      "subject": "admin-subject-123",
+      "role": "admin",
+      "project": "00000000-0000-0000-0000-000000000001"
+    }


Can we add a github action "user" here?

Suggested change

{

"displayName": "Mock Admin",

"subject": "admin-subject-123",

"role": "admin",

"project": "00000000-0000-0000-0000-000000000001"

}

{

"displayName": "Mock Admin",

"subject": "admin-subject-123",

"role": "admin",

"project": "00000000-0000-0000-0000-000000000001"

},

{

"displayName": "githubactions/repo:myorg/myrepo:ref:refs/heads/main",

"subject": "githubactions/repo+myorg/myrepo+ref+refs/heads/main",

"role": "editor",

"project": "00000000-0000-0000-0000-000000000001"

},

evankanderson · 2026-05-05T21:49:47Z

+// GetPermissionsClient is a helper to get the PermissionsServiceClient, supporting mocks
+func GetPermissionsClient(cmd *cobra.Command) (minderv1.PermissionsServiceClient, func(), error) {


Switch this to cli.GetGRPCClient?

evankanderson · 2026-05-05T21:50:16Z

 // DenyCommand is the command for removing a role assignment from a project
-func DenyCommand(ctx context.Context, cmd *cobra.Command, _ []string, conn *grpc.ClientConn) error {
-	client := minderv1.NewPermissionsServiceClient(conn)
+func DenyCommand(cmd *cobra.Command, _ []string) error {


I wonder why this function is exported. Can you switch it to denyCommand?

evankanderson · 2026-05-05T22:41:26Z

 // GrantCommand is the command for granting roles
-func GrantCommand(ctx context.Context, cmd *cobra.Command, _ []string, conn *grpc.ClientConn) error {
-	client := minderv1.NewPermissionsServiceClient(conn)
+func GrantCommand(cmd *cobra.Command, _ []string) error {


Ditto on unexporting this unless we need it exported (you'll also need to fix line 32)

Suggested change

func GrantCommand(cmd *cobra.Command, _ []string) error {

func grantCommand(cmd *cobra.Command, _ []string) error {

evankanderson · 2026-05-05T22:42:32Z

 		t.Render()
 		if len(resp.Invitations) > 0 {
-			t := initializeTableForGrantListInvitations(cmd.OutOrStdout())
+			t2 := initializeTableForGrantListInvitations(cmd.OutOrStdout())


Why change this name? I see that this t is shadowing the one in the outer scope, but that doesn't seem to be a problem.

evankanderson · 2026-05-05T22:45:34Z

-// listCommand is the command for listing projects
-func createCommand(ctx context.Context, cmd *cobra.Command, _ []string, conn *grpc.ClientConn) error {
-	client := minderv1.NewProjectsServiceClient(conn)
+// createCommand is the command for listing projects


Suggested change

// createCommand is the command for listing projects

// createCommand is the command for creating a new project

evankanderson · 2026-05-05T22:46:06Z

-	client := minderv1.NewProjectsServiceClient(conn)
+// createCommand is the command for listing projects
+func createCommand(cmd *cobra.Command, _ []string) error {
+	client, cleanup, err := GetProjectsClient(cmd)


Switch to cli.GetGRPCClient

evankanderson · 2026-05-05T22:46:48Z

-// listCommand is the command for listing projects
-func deleteCommand(ctx context.Context, cmd *cobra.Command, _ []string, conn *grpc.ClientConn) error {
-	client := minderv1.NewProjectsServiceClient(conn)
+// deleteCommand is the command for listing projects


Suggested change

// deleteCommand is the command for listing projects

// deleteCommand is the command to permanently delete a project

added unit test files for project and project role

df53611

Signed-off-by: DharunMR <maddharun56@gmail.com>

DharunMR requested a review from a team as a code owner April 25, 2026 03:09

evankanderson reviewed Apr 27, 2026

View reviewed changes

evankanderson mentioned this pull request Apr 29, 2026

feat(cli): improve evaluation reasoning output using existing fields #6417

Merged

evankanderson reviewed May 5, 2026

View reviewed changes

		// GetPermissionsClient is a helper to get the PermissionsServiceClient, supporting mocks
		func GetPermissionsClient(cmd *cobra.Command) (minderv1.PermissionsServiceClient, func(), error) {

	func GrantCommand(cmd *cobra.Command, _ []string) error {
	func grantCommand(cmd *cobra.Command, _ []string) error {

	// createCommand is the command for listing projects
	// createCommand is the command for creating a new project

	// deleteCommand is the command for listing projects
	// deleteCommand is the command to permanently delete a project

Conversation

DharunMR commented Apr 25, 2026 • edited by evankanderson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

🧪 How to Test

Uh oh!

coveralls commented Apr 25, 2026

Uh oh!

evankanderson left a comment

Choose a reason for hiding this comment

Uh oh!

DharunMR commented Apr 28, 2026

Uh oh!

evankanderson commented Apr 30, 2026

Uh oh!

sachin9058 commented Apr 30, 2026

Uh oh!

evankanderson commented Apr 30, 2026

Uh oh!

evankanderson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DharunMR commented Apr 25, 2026 •

edited by evankanderson

Loading