Paginate /codes endpoint#3685
Open
dsubak wants to merge 16 commits into
Open
Conversation
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
dsubak
commented
Jun 17, 2026
| # We have seats available, so grab some more codes. | ||
| codes_for_output = list(discounts.all()[: contract.max_learners]) | ||
|
|
||
| paginator = PageNumberPagination() |
Contributor
Author
There was a problem hiding this comment.
It sucks to do this in the view itself - we should probably bite the bullet and paginate the whole viewset.
jkachel
requested changes
Jun 23, 2026
jkachel
left a comment
jkachel
left a comment
Contributor
There was a problem hiding this comment.
One small thing, but otherwise ready to go.
Contributor
Author
|
@jkachel Think this is ready for another look! |
dsubak
force-pushed
the
dansubak/202606_paginated_codes
branch
from
6351d78 to
6b1146e
Compare
dsubak
commented
Jun 24, 2026
| class ManagerContractOrgPagination(PageNumberPagination): | ||
| page_size = 25 | ||
| page_size_query_param = "page_size" | ||
| max_page_size = 100 |
Contributor
Author
There was a problem hiding this comment.
Spoke w/ @daniellefrappier18 about using the /codes endpoint directly to support the export to csv behavior. At the moment, we think we can use that endpoint directly and reconstruct the payload as a CSV on the frontend - it'll just mean we specify a page_size large enough to pull back all rows in one shot.
I'm gonna need to remove this max_page_size endpoint to facilitate this approach. We may need to revisit it if this endpoint is too slow or the response too big to come back but for now we'll explore this approach and revisit it if it causes issues.
…igned codes from /codes output. Add filtering on assigned + redeemed statuses (#3705)
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/11375
Description (What does it do?)
search_termargument which is used to search across assigned emails and names or redeemed user emails and names.How can this be tested?
Pagination
Filtering
Additional Info