Add tests for B2B manager permissions#3712
Merged
Merged
Conversation
Introduce a new `b2b/permissions_test.py` suite for `IsOrganizationManager`, covering both `has_permission` and `has_object_permission`. The tests verify superuser bypass, authenticated manager access, denial for non-managers/other orgs/missing org IDs, and object-level org resolution across `organization_id`, `organization`, `b2b_contract`, and `run.b2b_contract` relationships.
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
for more information, see https://pre-commit.ci
dsubak
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
NA
Description (What does it do?)
Introduce a new
b2b/permissions_test.pysuite forIsOrganizationManager, covering bothhas_permissionandhas_object_permission. The tests verify superuser bypass, authenticated manager access, denial for non-managers/other orgs/missing org IDs, and object-level org resolution acrossorganization_id,organization,b2b_contract, andrun.b2b_contractrelationships.How can this be tested?
Tests should pass. There weren't any unit tests for this code previously.